Reduce memory consuption by doing in place calculations #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teutoburg
reviewed
Dec 16, 2023
Comment on lines
+114
to
+115
| #obj.hdu.data = new_image + bkg_level | ||
| obj.hdu.data -= bkg_level |
Contributor
There was a problem hiding this comment.
This used to be an addition and is now a subtraction? Also, what happened to new_image?
Collaborator
Author
There was a problem hiding this comment.
Ugh sorry for wasting your time, I didn't run the test suite :-(
Contributor
There was a problem hiding this comment.
Happens to me as well sometimes 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the memory consumption of a simple MICADO + SCAO + SPEC_15000x20 + detector_window simulation form 8.3 GB to 5.9 GB.
Might need some cleanup at some point.
Resulting pixel values are identical.