Fvpsf #403
Open
Fvpsf #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preliminary implementation of GridFieldVaryingPSF for convolving FOVs with field-varying PSFs using interpolation. The implementation might look somewhat convoluted, and it does not rely on many existing Numpy and SciPy methods, but this is done purposely to enable Numba compilation and parallelization. Missing: - Defining the structure of the input PSF grid; - Reading PSF grid coordinates and perform correct positioning of the PSF; - Kernel normalization; - Expand for multiple wavelengths.
Release candidate of PSF effect using a grid of PSFs that are interpolated across the field. Working example, but further testing required. No multiple-wavelength compatibility yet. - Compatibility with 3.5 lost (uses f-strings). Though these seem to be used in other places, so it probably was lost before. - Some docstring incomplete, mostly due to obfuscated attributes or missing or not well-defined type hints.
Raising exceptions for pixels out of bounds during numba routines wasn't working, so it was removed and made it compulsory that the coordinates to be computed lie withing the PSF grid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing #208, because we still want to add a field varying PSF