Skip to content

Conversation

@teutoburg
Copy link
Contributor

@teutoburg teutoburg commented Nov 19, 2024

Sibling of AstarVienna/irdb#201.

@teutoburg teutoburg self-assigned this Nov 19, 2024
@teutoburg teutoburg added the enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) label Nov 19, 2024
@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.08%. Comparing base (86c3e1f) to head (c689b9e).

Files with missing lines Patch % Lines
scopesim/commands/user_commands.py 29.41% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   77.16%   77.08%   -0.09%     
==========================================
  Files          66       66              
  Lines        8204     8218      +14     
==========================================
+ Hits         6331     6335       +4     
- Misses       1873     1883      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@teutoburg
Copy link
Contributor Author

Now codecough is complaining, perhaps we should put a status also in tests/mocks/basic_instrument/default.yaml to simulate all of this...

@teutoburg teutoburg marked this pull request as ready for review November 19, 2024 22:11
@teutoburg teutoburg requested a review from hugobuddel November 19, 2024 22:11
@hugobuddel
Copy link
Collaborator

Now codecough is complaining, perhaps we should put a status also in tests/mocks/basic_instrument/default.yaml to simulate all of this...

I think we should indeed test this, otherwise it will bite us at some point. Or it is implicitly tested through the IRDB I guess right? (Maybe we should add coverage support to ScopeSim_Data?)

Turns out, codecov is useful after all...
@teutoburg teutoburg requested a review from astronomyk November 25, 2024 11:03
Copy link
Collaborator

@astronomyk astronomyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verbally discussed. In Ordnung 👍

@teutoburg teutoburg merged commit 4309816 into main Nov 25, 2024
19 checks passed
@teutoburg teutoburg deleted the fh/pkg-status branch November 25, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants