-
Notifications
You must be signed in to change notification settings - Fork 13
Functionality for MOSAIC minimum viable product #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
- Coverage 75.88% 74.86% -1.02%
==========================================
Files 70 69 -1
Lines 8629 8627 -2
==========================================
- Hits 6548 6459 -89
- Misses 2081 2168 +87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
teutoburg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you tested that it mostly does what it should. My two comments can be ignored. I also ignored any linting-based nitpicking for now. The failing docs build is unrelated and has been fixed on main, so no worries there either.
This PR implements Scopesim functionality that enables a very simple ETC-like implementation of MOSAIC. The main effect is
MosaicSpectralTraceList, which collapses FOV cube to one-dimensional spectra by integrating over the fibre apertures and maps the 1D spectra onto the ImagePlane. The second new effect isMosaicCollapseSpectralTraceswhich adds up all the 1D spectra from the fibre bundle into a total spectrum. This is saved as a FITS table.Since the effects are implemented in an instrument-specific manner, no existing functionality should be affected by this PR.
The PR has tests for the new
Transform1Dclass but for the traces and trace lists it relies on tests for the parent classes.