Skip to content

Conversation

@oczoske
Copy link
Collaborator

@oczoske oczoske commented Sep 17, 2025

This PR implements Scopesim functionality that enables a very simple ETC-like implementation of MOSAIC. The main effect is MosaicSpectralTraceList, which collapses FOV cube to one-dimensional spectra by integrating over the fibre apertures and maps the 1D spectra onto the ImagePlane. The second new effect is MosaicCollapseSpectralTraces which adds up all the 1D spectra from the fibre bundle into a total spectrum. This is saved as a FITS table.
Since the effects are implemented in an instrument-specific manner, no existing functionality should be affected by this PR.
The PR has tests for the new Transform1D class but for the traces and trace lists it relies on tests for the parent classes.

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 38.92617% with 91 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.86%. Comparing base (886c349) to head (9c315d9).
⚠️ Report is 226 commits behind head on main.

Files with missing lines Patch % Lines
scopesim/effects/mosaic_trace_list.py 38.77% 90 Missing ⚠️
scopesim/effects/metis_lms_trace_list.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
- Coverage   75.88%   74.86%   -1.02%     
==========================================
  Files          70       69       -1     
  Lines        8629     8627       -2     
==========================================
- Hits         6548     6459      -89     
- Misses       2081     2168      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oczoske oczoske requested a review from teutoburg September 17, 2025 11:20
@oczoske oczoske added enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) instrument-specific effects Related to a ScopeSim effect Science Team Scientific target audience spectroscopy Related to spectroscopic modes labels Sep 17, 2025
@oczoske oczoske moved this to 👀 In review in ScopeSim for MOSAIC Sep 17, 2025
@oczoske oczoske moved this to 👀 Awaiting Review in ScopeSim-development Sep 17, 2025
@oczoske oczoske added this to the Vienna ELT Conference 2 milestone Sep 17, 2025
@oczoske oczoske linked an issue Sep 17, 2025 that may be closed by this pull request
@oczoske oczoske marked this pull request as ready for review September 17, 2025 11:22
Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tested that it mostly does what it should. My two comments can be ignored. I also ignored any linting-based nitpicking for now. The failing docs build is unrelated and has been fixed on main, so no worries there either.

@oczoske oczoske merged commit e161381 into main Sep 17, 2025
27 of 30 checks passed
@oczoske oczoske deleted the oc/mosaic branch September 17, 2025 12:53
@github-project-automation github-project-automation bot moved this from 👀 Awaiting Review to ✅ Done in ScopeSim-development Sep 17, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in ScopeSim for MOSAIC Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effects Related to a ScopeSim effect enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) instrument-specific Science Team Scientific target audience spectroscopy Related to spectroscopic modes

Projects

Status: ✅ Done
Archived in project

Development

Successfully merging this pull request may close these issues.

MOSAIC Minimum Viable Product

3 participants