Merge dev_master in preparation for release #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update METIS LSS traces
Fix workflows after ScopeSim main change
Patch problematic notebook
Try putting quantization as the final effect to avoid numpy issues that otherwise occur when adding floats to ints.
This used to be identical in the previously default *_sci.fits trace files, and causes a silent error when attemting to include the trace efficiencies.
Rename trace file extensions to match grating efficiency filenames
Add Quantization effect to METIS detector yamls
Template for working with IFU for Metis
Add IFU_Template Notebook
Adapt to changes in ScopeSim
Specify exptime in properties not arguments
Test whether exptime is honored.
add rectification, needs cleaning
Update of demo notebooks
Astropy units were used in this notebook in some parts, but not in others, which led to some inconsistencies. During the flux calibration, the background subtraction was scaled with the exposure time of the standard star, which I believe should not be the case. This also leads to a more realistic scaling factor in the final spectrum comparison (unless I'm missing something, scaling the source *down* to the result makes more sense, as the flux should decrease as it passes through the optical train). Also made some plots look a little nicer and simplified some of the code.
Further clean up YSO notebook, apply units consistently
Supply cube as hdul and not just file name
The plot from here popped up during collection time (?) when running pytest locally on the whole IRDB repo. This interrupted pytest until the figure window is closed manually.
Set PLOTS to False
This should fix #193.
Explicitly pass DIT/NDIT as None
Remove Python 3.9 from CI matrix
These should be evaluated for their usefulness elsewhere and then moved there or deleted completely. This is a temporary solution to stop the ScopeSim_Data runs from failing.
Disable all tests in MICADO_Sci
This might be able to fix the most recent ScopeSim_Data fail🤞
...to silence warnings from workflow runs.
Use lxml[html_clean] instead of just lxml
Update actions versions
Update readme for MICADO_Sci, clearly state deprecation
Add package and mode status keywords and guide
Contributor
Author
|
The failing tests are only because the new version of the artifact uploader fails for duplicate names, which occur because the badge reports are created in every combination. This should be fixed at some point (maybe soon-ish to avoid the fails), but is unrelated to the changes to the instrument packages (or indeed any functional part of anything here), so it's fine to ignore that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the instrument packages had changes since the last release. We should have new versions for the Workshop / Conference later this week.