Skip to content

Conversation

@oczoske
Copy link
Collaborator

@oczoske oczoske commented Mar 24, 2025

Use ExposureOutput in img_lm (to be expanded to other modes), see AstarVienna/ScopeSim#603

@teutoburg teutoburg added instrument-specific Limited to a certain IRDB instrument package instrument definition Addition or modification of instrument YAMLs METIS labels Mar 25, 2025
@teutoburg teutoburg moved this from 🆕 New to 🏗 In progress in ScopeSim-development Mar 25, 2025
@oczoske oczoske changed the title Use ExposureOutput for img_lm Use ExposureOutput in METIS Mar 25, 2025
@oczoske
Copy link
Collaborator Author

oczoske commented Mar 25, 2025

I have added ExposureOutput in all modes now. For img_n there is a question of order. I have now put averaging and quantisation (soonish to be replaced by adconversion) before chopnod, but this isn't correct either: already chopped images cannot be represented by uint16 (unless one uses BZERO).

@oczoske
Copy link
Collaborator Author

oczoske commented May 26, 2025

Trying to sum up where we stand:

  • tests are green, after fixing a stupid oversight
  • The METIS example notebooks need to be checked and revised, because they do not expect AD_Conversion and with SummedExposure are not unlikely to saturate the detector output.
  • The switch from SummedExposure to averaged exposure may be unexpected by some users. It shouldn't affect signal-to-noise ratio and therefore won't change "scientific" results.
  • It is not clear how this effect (and AD_Conversion) should work with the ChopNodCombiner (a shortcut effect).

@teutoburg teutoburg linked an issue May 27, 2025 that may be closed by this pull request
@oczoske oczoske marked this pull request as ready for review June 3, 2025 14:31
@teutoburg teutoburg self-requested a review June 3, 2025 16:26
Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teutoburg teutoburg merged commit 447acad into dev_master Jun 16, 2025
8 checks passed
@teutoburg teutoburg deleted the oc/exposureaction branch June 16, 2025 13:48
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in ScopeSim-development Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instrument definition Addition or modification of instrument YAMLs instrument-specific Limited to a certain IRDB instrument package METIS

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add ExposureOutput to METIS

3 participants