Oc/subsystem fits keywords

[oczoske]

This PR adds ExtraFitsKeywords to the various METIS subsystems. The goal is to automatise setting keywords consistent with current knowledge of the observing templates and METIS FITS keyword definitions (these definitions have gaps so expect updates to the settings at a later stage of the project).

• METIS.yaml: headers/FITS_cfo_keywords.yaml
• METIS_IMG_LM.yaml: headers/FITS_img_lm_keywords.yaml
• METIS_IMG_N.yaml: headers/FITS_img_n_keywords.yaml
• METIS_LMS.yaml: headers/FITS_lms_keywords.yaml
• METIS_LSS.yaml: headers/FITS_lss_keywords.yaml
• METIS_DET_IMG_LM.yaml: headers/FITS_det_img_lm_keywords.yaml
• METIS_DET_IMG_N_Geosnap.yaml: headers/FITS_det_img_n_geosnap_keywords.yaml
• METIS_DET_IFU.yaml: headers/FITS_det_ifu_keywords.yaml

Spectral keywords cannot be written yet due to a scopesim issue (AstarVienna/ScopeSim#644; conflicting redefinitions of __getitem__ in OpticsManager, Effect and SpectralTracelist).

[teutoburg]

@oczoske
#-strings need !-prefix to be resolved

Wouldn't that be a suffix?

[oczoske]

Things that are problematic:

• Spectral modes cannot access meta keywords (Conflicting definitions of __getitem__ in Effect and SpectralTraceList ScopeSim#644)
• LSS mode cannot add filter to ESO.DPR.TECH: there is one yaml METIS_LSS.yaml covering all three filters.
• INS.OPTI9 (mask/grism): The value should read GRISM_L etc. (according to the template manual). The best I can do for now is to set the trace file (TRACE_LSS_L.fits), but that should be translated somehow. One possibility might be to define grism_name in default.yaml and derive #spectral_traces.filename from that.

[oczoske]

I've listed everyone (but not their dogs) as reviewers. Please have a look at the FITS_*.yaml files whether you need additional keywords for your pipeline recipes.

[janusbrink]

Need a way to select IFU mode as an LMS sub-mode, with DPR.TECH = IFU and IFU mechanism IN?

[oczoske]

That's in FITS_lms_keywords.yaml (OPTI4 for the LMS pickoff). I'm changing DPR.TECH to IFU, in accord with the templates.

[wkausch]

Hi Oliver, thx for the implementation of the keywords. For the LSS we'll need also the used slits (following the DRLD that's INS.OPTI3.NAME) and the corresponding grism for the N-band (INS.OPTI12.NAME). Also for the metis_lm_lss_wave recipe the keyword SEQ.WCU.LASERn.

[oczoske]

OPTI3 is in FITS_cfo_keywords.yaml. OPTI12 is now present, and along with OPTI9 gets the correct name. I've added the SEQ.WCU.LASERn but set them all to ON - in scopesim they'd be all on at the same time, and it's actually a bit tricky to decide whether they are on or off... Which lamp is used is currently in SEQ.LAMP.NAME (which is not an official keyword). Can you work with that?

[wkausch]

OPTI3 is in FITS_cfo_keywords.yaml. OPTI12 is now present, and along with OPTI9 gets the correct name. I've added the SEQ.WCU.LASERn but set them all to ON - in scopesim they'd be all on at the same time, and it's actually a bit tricky to decide whether they are on or off... Which lamp is used is currently in SEQ.LAMP.NAME (which is not an official keyword). Can you work with that?

Yes, for the time being that should be fine, many thanks!

[hugobuddel]

Great! Thanks @oczoske !

All of them look fine. I didn't compare them with any documents though.

[hugobuddel]

oops, thanks

[teutoburg]

I don't know enough about this to give a meaningful review, but I don't see any immediate problems from the ScopeSim side of things.