Skip to content

Merge dev_master in preparation for release #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
teutoburg wants to merge 37 commits into from
Closed

Merge dev_master in preparation for release #234

teutoburg wants to merge 37 commits into from

Conversation

@teutoburg
Copy link
Contributor

@teutoburg teutoburg commented May 13, 2025 •
edited
Loading

Changed

ELT

  • 🗂️ header keywords

METIS

  • 🗂️ header keywords
  • 🚧 Quantization ➡️ ADConversion
    ⚠️ requires ScopeSim v0.10, not yet released!
  • 📓 docs
  • ✅ tests

oczoske and others added 30 commits August 22, 2024 15:34
@oczoske
Rename ADConversion, introduce gain
829130f
@oczoske
rename effect, add gain
5e7f010
@oczoske
Set gains
105c978
@teutoburg
Replace deprecated dt.utcnow() in publish script
9e346e0
@teutoburg
Use the one that py3.10 also understands...
2d5d14a
@teutoburg
Merge pull request #223 from AstarVienna/fh/utc
8cac0ed 
Replace deprecated `datetime.utcnow()` in publish script
@astronomyk @teutoburg
Extracted TEL keywords from METIS common keywords so WCU mode doesn't…
d604420 
… crash
@teutoburg
Remove mention of FITS keyword effect in WCU notebook
c72a7b8
@oczoske
multiple test gain values
1fcd147
@astronomyk
Move TEL header keywords in METIS to ELT (#227)
7bb259e 
Thanks for the work in the background @teutoburg
@oczoske
WCU FITS header keywords
9d2bfca
@oczoske
Move to headers/ directory to escape test
a756707
@oczoske
img_lm keywords
ae2a52d
@oczoske
#-strings need !-prefix to be resolved
d6eaa27
@oczoske
Change ID to DESC
b4ca54b
@oczoske
Change ID to DESC
81507ef
@oczoske
WCU FITS header keywords (#228)
e2d3aa2
@oczoske
Merge branch 'dev_master' into oc/subsystem_fits_keywords
13e257d
@oczoske
CFO keywords; INS_MODE
5ff3551
@oczoske
actual CFO keywords
1715f8b
@oczoske
lms keywords (partial); move ins_mode to properties
ca96bdd
@oczoske
add IMG_N; add DPR.TECH
ebf9677
@oczoske
add LSS keywords
fed41ee
@oczoske
Detector keywords
7e54bd0
@oczoske
add chopnod keywords; add detector mode
07281bf
@oczoske
DPR.TECH -> IFU
5893a7c
@oczoske
set grism names; insert LASER keywords
2f228e2
@oczoske
Set IFU gain to 2.0
940e3b3
@oczoske
ADConversion effect (#189)
18747b8
@oczoske
remove two more mentions of quantization
33f79e7
oczoske and others added 7 commits April 26, 2025 21:58
@oczoske
fix test that failed due to saturated detector readout
560c59c
@teutoburg
Fix test class that should be a function
b3eb41b 
A very similar thing occurred recently but I cannot find it right now: The code for this test was in the class body (as opposed to within a method), so it was executed during collection time and not a an actual test. Simple solution: just make it a function, it's just a single test case anyway.
@teutoburg
Fix test class that should be a function (#231)
1a109e0
@teutoburg
Minor cleanup in WCU notebook
e8f438a 
I never saw plots anymore (after some update to Jupyter months ago) unless
I explicitly added `plt.show()` everywhere. Finally figured out that
_removing_ the `%matplotlib inline` solves that. Now I don't know if this
breaks it for anyone else?

Also added the new `sim.link_irdb()`, let's see if that also works on RTD.
@oczoske
Resolve conflicts with dev_master
4034814
@oczoske
Oc/subsystem fits keywords (#229)
160d77d
@teutoburg
Minor cleanup in WCU notebook (#230)
6c83a52
@teutoburg teutoburg marked this pull request as ready for review May 13, 2025 10:52
@teutoburg teutoburg requested a review from oczoske May 13, 2025 10:52
@teutoburg
Copy link
Contributor Author

teutoburg commented May 13, 2025

Tests against ScopeSim release fail because ADConversion is not yet released. I'm fine with ignoring that for now, although as mentioned I think it would be useful to add a needs_scopesim: 0.10.0 key in the package metadata. But that's for later...

@oczoske
Copy link
Collaborator

oczoske commented May 13, 2025

How does this avoid breaking people's scopesim runs if the instrument package asks for a ADConversion effect that does not exist in the current (pip) scopesim version?

@teutoburg
Copy link
Contributor Author

teutoburg commented May 13, 2025

How does this avoid breaking people's scopesim runs if the instrument package asks for a ADConversion effect that does not exist in the current (pip) scopesim version?

It doesn't.

After a brief offline discussion, we decided that this isn't ready yet, and to rather create dev version tags and package those. This release should be made only after ScopeSim v0.10.0 is released (probably next week).

@teutoburg teutoburg closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oczoske oczoske Awaiting requested review from oczoske

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@teutoburg @oczoske @astronomyk