Default pupil masks and psfs for wcu modes #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oczoske
added
data update
teutoburg
approved these changes
Nov 26, 2025
Contributor
teutoburg
left a comment
teutoburg
left a comment
There was a problem hiding this comment.
See comment. Otherwise go 👍 (or perhaps wait for the ScopeSim counterpart?)
| ra: 0.0 | ||
| dec: 0.0 | ||
| # These defaults are overruled by the individual modes: | ||
| psf_name: none |
Contributor
There was a problem hiding this comment.
What will be used as the default PSF now? Previously, it was PSF_SCAO_9mag_06seeing.fits, but now I don't see any actual filename as a default. Just to make sure a default METIS simulation now still uses a PSF at all.
Collaborator
Author
There was a problem hiding this comment.
The sky modes all have a psf_file (in default.yaml). I'll check whether that still works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WCU modes use "perfect" PSFs computed by Roy van Boekel for the various pupil masks. The PR places all pupil masks in the pupil wheel in the WCU (
METIS_WCU.yaml). This differs from the instrument configuration where the masks are in several wheel in the CFO, the imager and the LMS. However, for the time being these PSFs are only used for AIT with the WCU. In a future version we may think about using them for on-sky observations as well.The default configuration uses the following pupil masks and their corresponding psfs:
Relates to AstarVienna/ScopeSim#832 and AstarVienna/ScopeSim#838