Skip to content

ReferencePixelBorder for METIS IMG-LM, IMG_N and LMS #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oczoske merged 4 commits into from
Nov 30, 2025
Merged

ReferencePixelBorder for METIS IMG-LM, IMG_N and LMS #293

oczoske merged 4 commits into from
Nov 30, 2025

Conversation

@oczoske
Copy link
Collaborator

@oczoske oczoske commented Nov 27, 2025 •
edited
Loading

Implements the reference pixels as in #292

The dimensions of the mask are recorded in the output fits headers of the image HDUs as ESO.DETi.CHIP.REFPIX.

@oczoske oczoske self-assigned this Nov 27, 2025
@oczoske oczoske added enhancement New feature or request instrument-specific Limited to a certain IRDB instrument package data update New version of or change to a data file instrument definition Addition or modification of instrument YAMLs METIS METIS AIT Issues related to METIS AIT simulations labels Nov 27, 2025
@oczoske
Copy link
Collaborator Author

oczoske commented Nov 27, 2025 •
edited
Loading

Some of the tests are currently broken, need to check.
--- later: the reference pixel mask messed up the means and sums (over the entire detector) that were used in the test. The test now runs without the mask, as before.

teutoburg
teutoburg approved these changes Nov 29, 2025
View reviewed changes
Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

METIS/headers/FITS_det_ifu_keywords.yaml
ESO:
DET3:
DIT: "!OBS.dit"
DIT: ["!OBS.dit", "[s]"]
Copy link
Contributor

@teutoburg teutoburg Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That just ... works? Nice!

@oczoske oczoske merged commit 8a855c6 into dev_master Nov 30, 2025
12 checks passed
@oczoske oczoske deleted the oc/839-detector_mask branch November 30, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teutoburg teutoburg teutoburg approved these changes

@JenniferKarr JenniferKarr Awaiting requested review from JenniferKarr

Assignees

@oczoske oczoske

Labels

data update New version of or change to a data file enhancement New feature or request instrument definition Addition or modification of instrument YAMLs instrument-specific Limited to a certain IRDB instrument package METIS AIT Issues related to METIS AIT simulations METIS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oczoske @teutoburg