Fix and improve package publishing infrastructure #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test case
The pysftp package is abandoned and was always just a wrapper for paramiko anyway, which itself is still actively supported and does all we need.
Those are more advanced anyway and the old publish_utils were initially copy-pasted from an older version there. We already imported ScopeSim anyway so this doesn't affect overall dependencies.
# Conflicts: # irdb/publish_utils.py
Add minimal docstring instead...
teutoburg
added
irdb functionality
teutoburg
changed the title
oczoske
approved these changes
Dec 3, 2025
Collaborator
oczoske
left a comment
oczoske
left a comment
There was a problem hiding this comment.
Not an in-depth review (basically because I'm out of my depth here), but I didn't see anything odd or suspicious glancing through the changes.
hugobuddel
approved these changes
Dec 4, 2025
Collaborator
hugobuddel
left a comment
hugobuddel
left a comment
There was a problem hiding this comment.
Certainly will make things better
github-project-automation
bot
moved this from 👀 Awaiting Review
to ✅ Done
in ScopeSim-development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most importantly, this fixes #258 and gets rid of the abandoned
pysftpas a dependency.While going through that part of the code, I also included a ton of cleanup and removed several long-deprecated and unused functionality, as well as some more mundane things like everyone's favorite, docstrings & formatting.