Add JWST and NIRCam packages #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teutoburg
added
the
instrument definition
oczoske
approved these changes
Dec 9, 2025
Collaborator
oczoske
left a comment
oczoske
left a comment
There was a problem hiding this comment.
Looks alright. Obviously I haven't checked the numbers. Example notebooks would be nice.
github-project-automation
bot
moved this from 👀 Awaiting Review
to ✅ Done
in ScopeSim-development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic versions of both for now, mostly because @astronomyk would like to recreate a comparison image between HST, JWST and MICADO. Some aspects like filter curves are more or less final, other like PSFs are a good initial approximation. The long wavelength imaging mode (the main one used here) currently uses a "fake" detector layout for simplification purposes, but the more accurate layout is already included.