Skip to content

Fix and cleanup WFC3 package 2/2 #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
teutoburg wants to merge 5 commits into
base: dev_master
Choose a base branch
from
Open

Fix and cleanup WFC3 package 2/2 #299

teutoburg wants to merge 5 commits into from

Conversation

@teutoburg
Copy link
Contributor

@teutoburg teutoburg commented Dec 11, 2025 •
edited
Loading

Continuation of #295.

  • Moved TER (aka filter curve) files (.dat) to subfolder for less crowded structure. @oczoske will be happy to see that I used git mv this time 🙃
  • Remove redundant FITS files that seem to have been used to create said TER files at some point. No real point in keeping those around for this package...
  • There was no PSF effect of any kind present in the package. A FITS file containing field varying PSF data was available, but to use it required Fix CUNIT not respected in FVPSF effect ScopeSim#851.
  • Various minor cleanup and formatting.

@teutoburg
Clean up WFC3 and HST yamls
375c3c9
@teutoburg
Move TER files to subfolder
a61eee6
@teutoburg
Remove redundant filter files
1dd43e6 
These were all converted to .dat anyway, but for some reason the original
.fits files were retained as well.
@teutoburg
Add PSF effect back in
5c5684e 
This required a fix in ScopeSim, which needs to be merged before this
can be used, hence bumping the needs_scopesim.
@teutoburg teutoburg self-assigned this Dec 11, 2025
@teutoburg teutoburg added instrument-specific Limited to a certain IRDB instrument package instrument definition Addition or modification of instrument YAMLs labels Dec 11, 2025
@teutoburg
Fix and cleanup WFC3 tests
03f90be 
Addition of FVPSF and changes to pixel border effect might be responsible
for ~0.2 % less flux than before.
@teutoburg teutoburg moved this to 👀 Awaiting Review in ScopeSim-development Dec 11, 2025
@teutoburg teutoburg marked this pull request as ready for review December 11, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astronomyk astronomyk Awaiting requested review from astronomyk

@oczoske oczoske Awaiting requested review from oczoske

Assignees

@teutoburg teutoburg

Labels

instrument definition Addition or modification of instrument YAMLs instrument-specific Limited to a certain IRDB instrument package

Projects

ScopeSim-development
Status: 👀 Awaiting Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teutoburg