Measured MICADO filter curves #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janusbrink
approved these changes
Dec 17, 2025
Contributor
janusbrink
left a comment
janusbrink
left a comment
There was a problem hiding this comment.
Looks good - thanks. So this update only includes the as-measured updates, which is fine since the as-designed values we have from Ric seems more accurate than the ones provided with the update.
Contributor
|
One slightly odd thing is that some measured values are > 100.00% (e.g. J-80K). Hope ScopeSim handles that OK... |
Collaborator
Author
|
Oh dear, what are these people measuring???
|
Contributor
|
It should be fine, yes - it's just due to the measurement error level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces a number of MICADO filter transmission curves with newly received measured data. The figure shows the new data in blue, compared to the old values in orange. The wavelength range could be restricted to the cut-off of the detectors. We're not doing that yet as we do not have measured quantum efficiency data on the actual detectors.