Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): use default formatter for yaml and turn off from docker_compose_language_service #1321

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

azdanov
Copy link
Contributor

@azdanov azdanov commented Jan 17, 2025

Closes #1309

📑 Description

This should turn off the default formatter from the docker_compose_language_service and use the one specified in the YAML pack to keep it all uniform and prevent double formatting if both packs are used at the same time. I encountered this issue with double formatting, which caused the code to jump up and down near the networks section.

Screencast_20250105_205931.webm

ℹ Additional Information

Maybe there is a better way. Feedback is welcome. 🙂

Copy link

github-actions bot commented Jan 17, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft Uzaaft merged commit bac0a03 into AstroNvim:main Jan 17, 2025
17 checks passed
@azdanov azdanov deleted the patch-1 branch January 18, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preffered yaml formatter for docker and yaml packs
2 participants