Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cord-nvim)!: update to v2 #1322

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

vyfor
Copy link

@vyfor vyfor commented Jan 17, 2025

📑 Description

cord.nvim has been completely rewritten from the ground up, with a plethora of new features and updates. These changes may not be fully compatible with the previous version of the plugin. After extensive testing, the new version has proven stable, and we plan to merge the v2 branch on February 1, 2025.

With v2, the plugin now follows semantic versioning. Additionally, the Rust compiler is no longer required to install the plugin, as the server component can now be easily downloaded via GitHub Releases using the async :Cord update command.

ℹ Additional Information

  • The minimum required Neovim version is bumped from 0.5.0 to 0.6.0. This is unlikely to affect AstroNvim users, as it already requires a much more recent version.
  • A migration guide is available, but we also encourage exploring the new configuration guide to make the most of Cord v2.
  • We've introduced support for icon themes, with onyx as the new default:
    397768447-df73221e-565b-49e5-9dad-1c60aed6f9c3

Copy link

github-actions bot commented Jan 17, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

Copy link
Member

@luxus luxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating lgtm
are there more changes necessary?

@vyfor
Copy link
Author

vyfor commented Jan 18, 2025

are there more changes necessary?

Not really, I'd just prefer to wait until the branch gets merged into master. While v2 is mostly stable and I could set the branch option to point to v2, I’ve noticed that for some reason, lazy.nvim often struggles to switch branches without requiring the user to manually delete the lazy/cord.nvim directory. It seems better to hold off until the merge.
Should I make another PR to pin the version to v1.0.0 for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants