Attempt to fix DREAMS #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fork does produce an image on the center two detectors:
I can't see from this thumbnail whether the image makes sense. But at least it is an image.
The biggest problem for me to do this properly is that I do not have the J-filter data, that is, I do not have
J.dat. Therefore I usedI.datfrom LFOA. @Astrogirlanajli could you include yourJ.datin the filters directory?So perhaps it is possible to ignore most filter/spectrum related changes. However, the curve in
TER_atmosphere.datlooks suspicious, since the wavelength claims to be in nanometer, but it ranges from 0.9 to 1.05, while the J band should be around 1200 nanometer. I simply added a (fake) data point at 1100 nanometer (to cover the I-band that I used).Other changes:
mage_plane_idtoimage_plane_idin DREAMS_InGaAs.yamlemission_unitto TER_atmosphere.datactiontransmissionto TER_atmosphere.dat (I thinktransmissionis the default, so this should not matter)---) to default.yaml to separate the two parts of the yaml file@Astrogirlanajli could you verify that you get some result using this branch?