Skip to content

Conversation

@hugobuddel
Copy link

@hugobuddel hugobuddel commented Jun 19, 2024

This fork does produce an image on the center two detectors:

starfieldwithdreams

I can't see from this thumbnail whether the image makes sense. But at least it is an image.

The biggest problem for me to do this properly is that I do not have the J-filter data, that is, I do not have J.dat. Therefore I used I.dat from LFOA. @Astrogirlanajli could you include your J.dat in the filters directory?

So perhaps it is possible to ignore most filter/spectrum related changes. However, the curve in TER_atmosphere.dat looks suspicious, since the wavelength claims to be in nanometer, but it ranges from 0.9 to 1.05, while the J band should be around 1200 nanometer. I simply added a (fake) data point at 1100 nanometer (to cover the I-band that I used).

Other changes:

  • Indenting of the rescaling parameters in DREAMS.yaml
  • Renaming mage_plane_id to image_plane_id in DREAMS_InGaAs.yaml
  • Converting the dark current to float in DREAMS_InGaAs.yaml (I'd say that this is a bug in ScopeSim)
  • Giving M1 some surface area (it was a 0-width ring), but this seems to have no effect
  • Adding an emission_unit to TER_atmosphere.dat
  • Adding action transmission to TER_atmosphere.dat (I think transmission is the default, so this should not matter)
  • Adding three dashes (---) to default.yaml to separate the two parts of the yaml file
  • Plot all 6 detectors

@Astrogirlanajli could you verify that you get some result using this branch?

rescale_emission:
filter_name: "!OBS.sky.filter_name"
filename_format: "filters/{}.dat"
filename_format: "filters/J.dat"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please put the file J.dat in the repository? In the directory filters. I do not have J.dat, so I cannot run the code with the J filter specified. That's why I used I.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants