Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add tasks (#1866) #1873

Merged
merged 1 commit into from
Mar 29, 2025
Merged

✨ Add tasks (#1866) #1873

merged 1 commit into from
Mar 29, 2025

Conversation

KATO-Hiro
Copy link
Collaborator

@KATO-Hiro KATO-Hiro commented Mar 29, 2025

close #1866

Summary by CodeRabbit

  • New Features

    • Expanded the contest classification system to support additional university contests, including the Kyoto University Programming Contest.
    • Updated contest identifier matching to recognize new contest patterns.
  • Documentation

    • Revised examples and descriptions to reflect the updated contest identifier formats.
  • Tests

    • Enhanced test coverage by including new contest identifiers and patterns to ensure robust contest classification.

Copy link

coderabbitai bot commented Mar 29, 2025

Walkthrough

This pull request extends contest support by updating contest identifier mappings and regex patterns to include KUPC contests. It adds KUPC-related test types, constants, and structured test data for multiple KUPC years, while also expanding test cases to cover a CODE FESTIVAL 2015 contest. The changes update both utility functions and test data, ensuring that contest problem import recognizes the new contest formats.

Changes

Files Change Summary
src/lib/.../contest.ts Updated contest identifiers and mappings; regex updated to include the ku prefix; documentation comments revised to reflect inclusion of KUPC.
src/test/lib/.../contest_name_and_task_index.ts Added new types (KupcYear, KupcTaskPatterns), constants (KUPC_TASK_PATTERNS, KUPC_YEARS), and structured KUPC test data (KUPC_TEST_DATA).
src/test/lib/.../contest_type.ts Expanded universityContestIds with new KUPC contest IDs and added a test case for CODE FESTIVAL 2015 contest in the atCoderOthers array.

Assessment against linked issues

Objective Addressed Explanation
Support importing KUPC contest problems (#1866)
Support importing CODE FESTIVAL 2015 contest problems (#1866)

Poem

I'm a bunny with a joyful beat,
Hopping through code with nimble feet.
KUPC comes alive in lines so neat,
Code festivals dance to a rhythmic tweet.
With every change, my heart does leap—
Celebrating updates like carrots to keep!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02e19e3 and 794cc1a.

📒 Files selected for processing (3)
  • src/lib/utils/contest.ts (4 hunks)
  • src/test/lib/utils/test_cases/contest_name_and_task_index.ts (2 hunks)
  • src/test/lib/utils/test_cases/contest_type.ts (2 hunks)
🔇 Additional comments (7)
src/test/lib/utils/test_cases/contest_type.ts (2)

258-273: Good addition of KUPC contest support

The addition of KUPC (Kyoto University Programming Contest) contest IDs to the universityContestIds array expands test coverage appropriately. The comment provides helpful context about when these contests were held (2012-2021, 2024+).


314-317: LGTM: Good test coverage expansion

The addition of a test case for 'CODE FESTIVAL 2015 あさぷろ Middle' improves coverage for the "OTHERS" contest type category.

src/lib/utils/contest.ts (3)

121-122: Good documentation update

The comment has been correctly updated to include KUPC in the list of university contests supported as of March 2025.


140-145: LGTM: Appropriate addition to ATCODER_UNIVERSITIES

The addition of kupc: 'KUPC' to the constant properly supports Kyoto University Programming Contest identifiers.


286-296: Correct regex update to support KUPC contests

The regex has been properly updated to include the ku prefix for matching KUPC contest identifiers, and the documentation has been updated with an appropriate example.

src/test/lib/utils/test_cases/contest_name_and_task_index.ts (2)

422-446: Well-structured KUPC test data implementation

The implementation of KUPC support follows good practices:

  1. Proper type definitions for KupcYear and KupcTaskPatterns
  2. Comprehensive task patterns for all KUPC years
  3. Structured test data generation that matches the pattern used for other university contests

This approach makes future maintenance easier and provides good test coverage.


539-544: LGTM: Correct integration with existing test data

The inclusion of KUPC_TEST_DATA in ALL_UNIVERSITY_TEST_DATA ensures the new KUPC test cases will be properly utilized in the test suite alongside other university contests.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KATO-Hiro KATO-Hiro merged commit 11f90d1 into staging Mar 29, 2025
3 checks passed
@KATO-Hiro KATO-Hiro deleted the #1866 branch March 29, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

問題をインポートできるようにしましょう
1 participant