Load feed in background task #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-task * post-view-image-reloading: - Continue downloading image at lower priority when PostUIView scrolls out of view. - Animate in image after downloading, for less jarring experience. - Remove nested `ForEach` inside `List` in `FeedView`, which was causing feed to load posts in batches, instead of lazily one by one. - Set image in-memory and disk limit to reasonable values. - Use inline closure to suppress actor warning. - Add Nuke package to replace AsyncImage. - Use Nuke LazyImage to load images. - Add @mainactor attribute to suppress actor warning. - Refactor subviews into private view builders. - Refactor subviews into private view builders. # Conflicts: # Leomard/Views/FeedView.swift
|
I've fixed the merge conflict and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance issues mentioned in #25:
PostUIView.task{ }to .background tasks.