Make sure we do not proxify our own proxy URL #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// Make sure we do not proxy ourself
if(stripos($url, app_url()) === 0){
return $base_url;
}
Extract PHP_URL_HOST from both URLs, remove "www.", and compare both including subdomain. So this way we don't proxy our own proxy. Tested and working perfectly.
Make sure the schema is only http and https (for security reasons).
|
This can be closed, I made a simple SecurityPlugin and submitted the PR here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside function proxify_url($url, $base_url = '') we make sure that:
Good improvements for security reasons.