Skip to content
This repository was archived by the owner on Aug 7, 2023. It is now read-only.

ci: use pulsar in ci #39

Merged
savetheclocktower merged 5 commits into from
Jul 11, 2023
Merged

ci: use pulsar in ci #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4adbdfd
ci: use pulsar in ci
UziTech Feb 14, 2023
17913e1
chore: use ppm on windows
scagood Jul 7, 2023
8b4b936
chore: only use one version of node per build
scagood Jul 7, 2023
810f723
chore: install npm packages on windows
scagood Jul 7, 2023
c0d9c36
ci: hack to install deps on windows (#1)
scagood Jul 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 25 additions & 24 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,33 +6,25 @@ on:

jobs:
Test:
name: ${{ matrix.os }} - Atom ${{ matrix.atom_channel }} - node ${{ matrix.node_version }}
name: ${{ matrix.os }} - Pulsar
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
atom_channel: [stable, beta]
node_version: ['lts/*']
include:
- os: ubuntu-latest
atom_channel: stable
node_version: '*'
os:
- ubuntu-latest
- macos-latest
- windows-latest
steps:
- uses: actions/checkout@v3
- uses: UziTech/action-setup-atom@v3
with:
version: ${{ matrix.atom_channel }}
- uses: pulsar-edit/action-pulsar-dependency@v3.3
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node_version }}
- uses: volta-cli/action@v1.7.0
node-version: 'lts/*'
- uses: volta-cli/action@v4
- name: Install multiple Node versions
if: runner.os != 'Windows'
run: |
volta install node@10
echo "NODE_10=$(volta which node)" >> $GITHUB_ENV
echo "NODE_10_VERSION=$(node --version)" >> $GITHUB_ENV
volta install node@latest
echo "NODE_LATEST=$(volta which node)" >> $GITHUB_ENV
echo "NODE_LATEST_VERSION=$(node --version)" >> $GITHUB_ENV
Expand All @@ -42,9 +34,6 @@ jobs:
- name: Install multiple Node versions (Windows)
if: runner.os == 'Windows'
run: |
volta install node@10
echo "NODE_10=$(volta which node)" >> $env:GITHUB_ENV
echo "NODE_10_VERSION=$(node --version)" >> $env:GITHUB_ENV
volta install node@latest
echo "NODE_LATEST=$(volta which node)" >> $env:GITHUB_ENV
echo "NODE_LATEST_VERSION=$(node --version)" >> $env:GITHUB_ENV
Expand All @@ -67,14 +56,26 @@ jobs:
npm init --yes
npm install eslint@latest
cd ..
- name: Install dependencies (Windows)
if: runner.os == 'Windows'
run: |
ppm install
npm install
npx atom-package-deps ./windows-deps
- name: Install dependencies
if: runner.os != 'Windows'
run: |
pulsar --package install
Copy link
Contributor Author

@scagood scagood Jul 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially tried to use ppm here, but it failed on macos.

I found that its disabled here, not sure why:
https://github.com/pulsar-edit/action-pulsar-dependency/blob/main/action.yml#L27

Copy link
Member

@savetheclocktower savetheclocktower Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@confused-Techie, do you remember why? ^^

Copy link

@confused-Techie confused-Techie Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only be commented out, in case someone wanted to symlink ppm, but the idea is we move fully over to using pulsar -p.

On a side note, @savetheclocktower is 100% right, you must still use apm on Windows. Plus the installer doesn't add anything to the path. You could run the tests from the path of the package after install, like I do here, when running on windows

Copy link
Contributor Author

@scagood scagood Jul 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, I ended up using a patched version atom-package-deps to install the packages on windows 🤔
For reference, both ppm, and pulsar -p did not install the package
I probably need to work out a better solution 😬

pulsar --package install linter-eslint
Copy link
Contributor Author

@scagood scagood Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this install does not work 😬

Copy link
Member

@savetheclocktower savetheclocktower Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think on Windows you've still got to use ppm instead of pulsar --package, so give that a shot. If that doesn't work, I'll summon another person from Pulsar core to help troubleshoot.

npx atom-package-deps .
- name: List dependencies
run: |
apm install
apm install linter-eslint
# ./node_modules/.bin/atom-package-deps .
pulsar --package list --enabled --packages

- name: Run tests 👩🏾‍💻
run: npm run test
uses: coactions/setup-xvfb@v1
with:
run: pulsar --test spec

Lint:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -105,7 +106,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: UziTech/action-setup-atom@v3
- uses: pulsar-edit/action-pulsar-dependency@v3.3
- uses: actions/setup-node@v3
with:
node-version: "lts/*"
Expand Down
Loading