-
Notifications
You must be signed in to change notification settings - Fork 0
Camera Control Component with websocket h264 stream provider #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stmudie
wants to merge
15
commits into
main
Choose a base branch
from
4-camera-control-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
37b92a4
Resolution, cropping, dragging for H264
stmudie e1e261d
Getting zoom and cropping working correctly.
stmudie 7713cde
Cleaning up using refs.
stmudie 9bf86bb
Formatted. Fixed references/state so that ws isn't reconnected on ima…
stmudie 832ed5b
sessionId injetion and cleanup with refs
stmudie 7c13ece
Working version before changing to using padding passed via API.
stmudie baf0a77
Using fixed crop resonse
stmudie 02ed30b
Space button for panning.
stmudie bfbd363
Use metadata from stream instead of rest to get current crop for drag…
stmudie a124d5c
Move camera control and related components/providers to a sub directory.
stmudie d997fa4
Add type definition for reused bounding box.
stmudie aab712d
Create default resolution constant
stmudie e413dc8
Added docstrings and small cleanup
stmudie 7d2c944
Change guarding for video frames by create isVideo
stmudie aa33784
Add default delay to debounce function and use it.
stmudie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this work in the docs if you don't have something running at localhost?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it won't. I wonder if there is a way to fake it for the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can implement a mock context that just emits some test images in a loop or something. If we mock out the API, we would still need a mock websocket that emits h264 I guess which sounds hard.