Skip to content

Exporter Materials Tagging [AARD-1880] - #1170

Merged
BrandonPacewic merged 29 commits into
devfrom
dhruv/1880/material-tagging
Jul 14, 2025
Merged

Exporter Materials Tagging [AARD-1880]#1170
BrandonPacewic merged 29 commits into
devfrom
dhruv/1880/material-tagging

Conversation

@Dhruv-0-Arora

@Dhruv-0-Arora Dhruv-0-Arora commented Jun 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Task

The Exporter Materials Tagging creates a new Exporter Tab called Tagging Options which allows users to:

  1. select a Fusion Body
  2. select a tag from a dropdown list
    which assigns that body the exporter tag selected.
Screenshot 2025-07-10 at 4 08 37 PM

AARD-1880

Solution

Features of this PR include

  • the "add" button will spawn the body selection UI
  • a "cancel" button will appear if currently selecting a body
  • Only 1 Fusion body can be selected at a time (+ only bodies are selectable).

Verification

  • Check if the .mira file that downloads on export contains the keyword "tag" -- see Components.py to see how the tags are exported

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@Dhruv-0-Arora Dhruv-0-Arora self-assigned this Jun 25, 2025
@Dhruv-0-Arora Dhruv-0-Arora added ui/ux Relating to user interface, or in general, user experience exporter Related to the Synthesis exporter labels Jun 25, 2025
@azaleacolburn azaleacolburn changed the title Materials Tagging [AARD-1880] Materials Tagging UI [AARD-1880] Jun 25, 2025
@Dhruv-0-Arora
Dhruv-0-Arora marked this pull request as ready for review June 25, 2025 22:39
@Dhruv-0-Arora
Dhruv-0-Arora requested review from a team as code owners June 25, 2025 22:39
@Dhruv-0-Arora
Dhruv-0-Arora marked this pull request as draft June 25, 2025 22:48
@Dhruv-0-Arora
Dhruv-0-Arora marked this pull request as ready for review July 8, 2025 17:40
BrandonPacewic
BrandonPacewic requested changes Jul 10, 2025
View reviewed changes

@BrandonPacewic BrandonPacewic left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that removing tags is not working correctly at the moment.
image

@Dhruv-0-Arora

Dhruv-0-Arora commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator Author

It appears that removing tags is not working correctly at the moment. image

@BrandonPacewic To remove a tag you need to select a row first (which the Fusion UI is really bad at for doing since you need to click in between the columns.) I will update the UI message though so it is clearer 👍

BrandonPacewic
BrandonPacewic requested changes Jul 10, 2025
View reviewed changes

@BrandonPacewic BrandonPacewic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to select a tag and delete it? Because I'm not able to.

@Dhruv-0-Arora

Dhruv-0-Arora commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator Author

Are you able to select a tag and delete it? Because I'm not able to.

Yes; With Zachs UI refactor it will be a lot easier to select and delete a tag but right now you can select a row:
Screenshot 2025-07-10 at 10 52 10 AM

and click remove

BrandonPacewic
BrandonPacewic reviewed Jul 10, 2025
View reviewed changes

@BrandonPacewic BrandonPacewic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't select a tag to remove.

Screen.Recording.2025-07-10.at.11.06.32.mov

azaleacolburn
azaleacolburn requested changes Jul 11, 2025
View reviewed changes
Comment thread exporter/SynthesisFusionAddin/src/UI/TaggingConfigTab.py
azaleacolburn
azaleacolburn approved these changes Jul 11, 2025
View reviewed changes

@azaleacolburn azaleacolburn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dhruv-0-Arora
Dhruv-0-Arora marked this pull request as draft July 11, 2025 20:43
@Dhruv-0-Arora
Dhruv-0-Arora marked this pull request as ready for review July 11, 2025 21:54
@Dhruv-0-Arora

Dhruv-0-Arora commented Jul 11, 2025

Copy link
Copy Markdown
Collaborator Author

Note

If you are trying to test out whether the tags are properly exported / access the tags themselves, you can do so by adding this line in MirabufSceneObject.ts (line 187)

console.log(this._mirabufInstance.parser.assembly.data?.parts?.userData)

Dhruv-0-Arora
Dhruv-0-Arora commented Jul 11, 2025
View reviewed changes
Comment thread exporter/SynthesisFusionAddin/src/Parser/SynthesisParser/Parser.py Outdated
BrandonPacewic
BrandonPacewic approved these changes Jul 14, 2025
View reviewed changes

@BrandonPacewic BrandonPacewic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Note for AARD-1883 and #1194, once a rigid body is selected it should be added to the table and material tag selection should be a dropdown within the table itself with rigid being the default.

@BrandonPacewic
Merge dev
688753e 
* dev: (27 commits)
  Disable Default Key Functions
  fix(snyk): update version requirements
  reorder dependencies
  chore(installer): update python packages to avoid vulerabilities
  Unused Imports Removed
  Merge Fix
  fix: clean up workflow spacing, use latest checkout and setup-node steps
  fix: use correct package.json path
  feat: add npm caching to all npm-involving workflows
  fix(merge): fix merging build issues from GH-1203
  Update fission/src/test/MirabufParser.test.ts
  New Endgame Sound & Updated Licensing Info
  Type & Removed Unnecessary Link
  Build Fix
  Documentation
  refactor: avoid having potentially undefined global functions
  Cleaner Code
  Unnecessary Tests Removed
  More Advanced Joint Testing
  ContactEvent Unit Tests
  ...
@BrandonPacewic BrandonPacewic mentioned this pull request Jul 14, 2025
Merged
@BrandonPacewic
BrandonPacewic merged commit 8c5e6b9 into dev Jul 14, 2025
16 checks passed
@BrandonPacewic
BrandonPacewic deleted the dhruv/1880/material-tagging branch July 14, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azaleacolburn azaleacolburn azaleacolburn approved these changes
@BrandonPacewic BrandonPacewic BrandonPacewic approved these changes
@rutmanz rutmanz rutmanz approved these changes
@PepperLola PepperLola Awaiting requested review from PepperLola PepperLola is a code owner automatically assigned from Autodesk/synthesis-admin

Assignees

@Dhruv-0-Arora Dhruv-0-Arora

Labels

exporter Related to the Synthesis exporter ui/ux Relating to user interface, or in general, user experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dhruv-0-Arora @azaleacolburn @BrandonPacewic @rutmanz