-
Notifications
You must be signed in to change notification settings - Fork 61
Height Limit Penalty [AARD-1999]
#1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaleacolburn
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
rutmanz
requested changes
Jul 22, 2025
rutmanz
approved these changes
Jul 22, 2025
azaleacolburn
approved these changes
Jul 23, 2025
BrandonPacewic
approved these changes
Jul 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm running out of ways to say looks good. So. This looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Implement a penalty tracker that detects if the robot exceeded the maximum allowed height during match mode, in which case a penalty is applied.
AARD-1999
Symptom
FRC has rules in certain years against extending past a certain height.
Solution
Implement a tracker that checks each robot height and verifies that they are under the height limit. If they are not a penalty is applied.
Verification
To test this I changed on of the match configs to have a value of 1.5. The 2471 robot with elevator fully down is just slightly below that height. Extending the elevator should cause a penalty to be applied (if in match mode).
Also check that
Before merging, ensure the following criteria are met: