Skip to content

Height Limit Penalty [AARD-1999] #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jul 25, 2025
Merged

Conversation

AlexD717
Copy link
Member

@AlexD717 AlexD717 commented Jul 22, 2025

Task

Implement a penalty tracker that detects if the robot exceeded the maximum allowed height during match mode, in which case a penalty is applied.

AARD-1999

Symptom

FRC has rules in certain years against extending past a certain height.

Solution

Implement a tracker that checks each robot height and verifies that they are under the height limit. If they are not a penalty is applied.

Verification

To test this I changed on of the match configs to have a value of 1.5. The 2471 robot with elevator fully down is just slightly below that height. Extending the elevator should cause a penalty to be applied (if in match mode).
Also check that

  • If ignore rotation is true, rotating the robot doesn't cause any penalties to be triggered
  • Penalties still apply with multiple robots
  • Penalties are not applied every frame
  • Penalty can be configured by uploading a custom match mode config

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 self-assigned this Jul 22, 2025
@AlexD717 AlexD717 added the gameplay Relating to the playability of Synthesis label Jul 22, 2025
@AlexD717 AlexD717 marked this pull request as ready for review July 22, 2025 19:01
@AlexD717 AlexD717 requested review from a team as code owners July 22, 2025 19:01
Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@azaleacolburn azaleacolburn self-requested a review July 22, 2025 21:03
@AlexD717 AlexD717 requested a review from BrandonPacewic July 25, 2025 17:11
* dev:
  Format
  Unit Test Fix
  Format
  Unconditional Overwrite Fix
  Format
  Camera tries to find a focus if no focus exists
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running out of ways to say looks good. So. This looks good.

@BrandonPacewic BrandonPacewic mentioned this pull request Jul 25, 2025
@BrandonPacewic BrandonPacewic merged commit 5d3df26 into dev Jul 25, 2025
16 checks passed
@BrandonPacewic BrandonPacewic deleted the alexey/1999/height-limit-penalty branch July 25, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gameplay Relating to the playability of Synthesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants