Skip to content

Conversation

@JJMinton
Copy link
Collaborator

This PR updates pythonocc-core from v7.5.1 to v7.8.1.
This required

  • updates to conda environment definitions
  • replace removed .Nodes().Value(idx) functions with .Node(idx).
  • Replace a number of functions with static methods to avoid deprecation warnings.

As a bonus, I have removed numerous unused imports.

@JJMinton JJMinton requested a review from JoeLambourne July 10, 2024 12:58
@JJMinton JJMinton force-pushed the mintonj/v7.8.1_upgrade branch from 088d25c to 0dbdce2 Compare July 10, 2024 13:17
Copy link
Contributor

@JoeLambourne JoeLambourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

I'm recommending updating the major version because we pull in a new PythonOCC which does force consumers to update OCC related code

@JJMinton
Copy link
Collaborator Author

I am getting failures around the read/write of shapesets. The interface was updated from .ReadFromString() to .Read(), as per this PR, but this is raising an error. I have opened an issue with pythonocc so will hold this for a while in hopes of getting a resolution.

@pradeep-pyro
Copy link
Collaborator

@JJMinton is this PR ready to merge?

@Late-March
Copy link

Late-March commented Jan 20, 2025 via email

@NarenR21
Copy link

Did this get merged? Would love to use 7.8.1 so that it doesn't break my other dependencies.

@Late-March
Copy link

Late-March commented Jun 18, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants