Skip to content

Conversation

@iangmaia
Copy link
Contributor

This PR prepares the release of version 3.12.0.

Changes in this version:

@iangmaia iangmaia added the enhancement New feature or request label Feb 21, 2025
@iangmaia iangmaia requested a review from a team February 21, 2025 22:53
@iangmaia iangmaia self-assigned this Feb 21, 2025
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically speaking this should be a breaking change and thus lead to a 4.0.0 major version bump 🤔

That being said I'm not sure anyone has started using the pr_changed_files yet since it was introduced, so this is probably fine…

But also, major version bumps are cheap to do, especialluy in buildkite-plugin land, as it's just a matter of how you name the version and tag, so… couldn't hurt to still do it?🤷‍♂️

@mokagio
Copy link
Contributor

mokagio commented Feb 24, 2025

For what is worth, I have a breaking change queue in #144, too.

But, as @AliSoftware said, tags are super cheap here, so we don't necessarily need to wait for it to merge and batch the two breaking changes.

@iangmaia iangmaia closed this Feb 24, 2025
@iangmaia iangmaia deleted the release/3.12.0 branch February 24, 2025 11:33
@iangmaia
Copy link
Contributor Author

major version bumps are cheap to do, especialluy in buildkite-plugin land, as it's just a matter of how you name the version and tag, so… couldn't hurt to still do it?

tags are super cheap here, so we don't necessarily need to wait for it to merge and batch the two breaking changes.

Agreed! And there was an issue with this PR: I created it from the last PR branch instead of trunk 🙈. So I've deleted this release branch and I'm gonna start with 4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants