-
Notifications
You must be signed in to change notification settings - Fork 5
Prepare release 3.12.0
#161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation updates Co-authored-by: Olivier Halligon <[email protected]>
… code, actual output, expected output
Co-authored-by: Olivier Halligon <[email protected]>
Co-authored-by: Olivier Halligon <[email protected]>
AliSoftware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically speaking this should be a breaking change and thus lead to a 4.0.0 major version bump 🤔
That being said I'm not sure anyone has started using the pr_changed_files yet since it was introduced, so this is probably fine…
But also, major version bumps are cheap to do, especialluy in buildkite-plugin land, as it's just a matter of how you name the version and tag, so… couldn't hurt to still do it?🤷♂️
|
For what is worth, I have a breaking change queue in #144, too. But, as @AliSoftware said, tags are super cheap here, so we don't necessarily need to wait for it to merge and batch the two breaking changes. |
Agreed! And there was an issue with this PR: I created it from the last PR branch instead of trunk 🙈. So I've deleted this release branch and I'm gonna start with |
This PR prepares the release of version 3.12.0.
Changes in this version:
pr_changed_filescommand to support both exit codes (default) and "true"/"false" string output (via--stdoutflag) [Enhance pr_changed_files with exit codes and string output #151]