-
Notifications
You must be signed in to change notification settings - Fork 3
Sign release build with distribution certificate #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
97d8ffd
Update Fastlane – Routine before further work
mokagio bd3f812
Extract logic for dev code signing fetch in dedicated lane
mokagio 93f6c6e
Add lane to fetch distribution certificate
mokagio f146bc0
Remove unused `readonly` option
mokagio 70d9a68
Do not attempt to create new certificate
mokagio 7cc53b0
Differentiate between development and release certificates
mokagio 934dd1d
Give up using `cert` for distribution certificate
mokagio 9e35184
DRY call to `sync_code_singing` for documentation purposes
mokagio 4d09be6
Add `--force` to `codesign` for debug too
AliSoftware 5d8e249
Remove useless Make target
AliSoftware 3bbeea2
Fix `set_up_certificate_in_keychain`
AliSoftware daecdaa
Add `fetch-codesigning*` recipes to `Makefile`
AliSoftware 6441b37
Make Rubocop more lenient on method length
AliSoftware File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also +1 on using the verbose flag name instead of the short, much clearer when reading the code.