Skip to content

Boost: Ensure Home URL is always a predefined Cornerstone Page #44275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: trunk
Choose a base branch
from

Conversation

LiamSarsfield
Copy link
Contributor

@LiamSarsfield LiamSarsfield commented Jul 10, 2025

Fixes HOG-195: Do not count the homepage as a cornerstone page for plan limits

Fixes HOG-204
Fixes HOG-215

Proposed changes:

  • Ensures the Home URL is not included within the user's Cornerstone Page plan.
  • Adds a new "Predefined" list of URLs (currently only homepage) that the user cannot edit.
Screenshot 2025-07-11 at 19 35 20

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@github-actions github-actions bot added [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress labels Jul 10, 2025
Copy link
Contributor

github-actions bot commented Jul 10, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 10, 2025
Copy link

jp-launch-control bot commented Jul 10, 2025

Code Coverage Summary

Coverage changed in 49 files. Only the first 5 are listed here.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/assets/src/js/features/cornerstone-pages/meta/meta.tsx 0/73 (0.00%) 0.00% 6 💔
projects/plugins/boost/app/lib/cornerstone/class-cornerstone-utils.php 1/22 (4.55%) 4.55% 1 ❤️‍🩹
projects/plugins/boost/app/data-sync/class-minify-excludes-state-entry.php 1/10 (10.00%) 10.00% -1 💚
projects/plugins/boost/app/lib/class-super-cache-tracking.php 1/2 (50.00%) 50.00% -1 💚
projects/plugins/boost/app/lib/critical-css/class-critical-css-state.php 1/99 (1.01%) 1.01% -1 💚

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

LiamSarsfield and others added 5 commits July 11, 2025 13:28
- Update CornerstonePages component to check if cornerstonePages is an array.
- Modify styles in meta.module.scss for better layout and spacing.
- Enhance CornerstonePagesContent to handle empty input correctly.
- Introduce useMemo for input validation state in List component.
- Refactor utility functions to manage predefined and custom Cornerstone Pages more effectively.
@kraftbj kraftbj added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels Jul 16, 2025
@kraftbj kraftbj added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jul 16, 2025
@kraftbj kraftbj marked this pull request as ready for review July 16, 2025 20:38
@kraftbj kraftbj requested a review from dilirity July 16, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Plugin] Boost A feature to speed up the site and improve performance. [Status] Needs Review This PR is ready for review. [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants