Skip to content

Fix CSS Minifier to Preserve Spaces in Mathematical Expressions in Nested CSS Structures #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrivediKavit wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −0
Open

Fix CSS Minifier to Preserve Spaces in Mathematical Expressions in Nested CSS Structures #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions cssmin/Minifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,13 @@ private function minify($css)
$css
);

// Process mathematical expressions so their operators don't get accidentally minified
$css = preg_replace_callback(
'/\b\d*\.?\d+[a-z%]*\s*[\+\-\*\/]\s*\d*\.?\d+[a-z%]*\b/Si',
array($this, 'processMathematicalExpressionCallback'),
$css
);

// Normalize all whitespace strings to single spaces. Easier to work with that way.
$css = preg_replace('/\s+/S', ' ', $css);

Expand Down Expand Up @@ -454,6 +461,16 @@ private function processStringsCallback($matches)
return $quote . $this->registerPreservedToken($match) . $quote;
}

/**
* Preserves mathematical expressions found
* @param array $matches
* @return string
*/
private function processMathematicalExpressionCallback($matches)
{
return $this->registerPreservedToken($matches[0]);
}

/**
* Preserves or removes comments found.
* @param string $css
Expand Down
Loading