Skip to content

Add HTML stripping option to makeLongWordsShort #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add HTML stripping option to makeLongWordsShort #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b995db
Add HTML stripping option to makeLongWordsShort
dd32 Sep 11, 2025
292eb67
Live Comments: Don't render HTML in titles of new posts
dd32 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions modules/live-comments/js/views/item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,14 @@ o2.Views.LiveCommentsWidgetItemView = ( function( $ ) {
initialize: function() {
},

makeLongWordsShort: function( content, limit ) {
makeLongWordsShort: function( content, limit, stripHTML ) {
if ( stripHTML ) {
// Rendering the content in a div is safe here, as we'll add it to the DOM later anyway, and we trust WordPress to have sanitized it.
var div = document.createElement( 'div' );
div.innerHTML = content;
content = div.textContent || div.innerText || content;
}

var contentArray = content.split( ' ' );
for ( var i=0; i < contentArray.length; i++ ) {
if ( contentArray[i].length > limit ) {
Expand All @@ -29,7 +36,7 @@ o2.Views.LiveCommentsWidgetItemView = ( function( $ ) {
render: function() {
var jsonifiedModel = this.model.toJSON();

jsonifiedModel.title = this.makeLongWordsShort( jsonifiedModel.title, 15 );
jsonifiedModel.title = this.makeLongWordsShort( jsonifiedModel.title, 15, true );
jsonifiedModel.author = o2.UserCache.getUserFor( this.model.attributes, 32 );

var titleForItem = jsonifiedModel.title,
Expand Down
2 changes: 1 addition & 1 deletion modules/live-comments/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ function live_item_templates() {
<# if ( 'comment' === data.type ) { #>
data-postid="{{ data.postID }}"
<# } #>
>{{{ data.title }}}</a>
>{{ data.title }}</a>
<br/>
<span class="entry-date o2-timestamp" data-unixtime="{{ data.unixtime }}" data-domref="{{ data.domRef }}"
<# if ( 'comment' === data.type ) { #>
Expand Down