Use JsonValue for post type supports field #1050
Conversation
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
Thanks for taking care of this – can we validate that we have a post_type_supports("editor") method somewhere that just checks for that key to be present? It seems like the actual data is pretty much a black box, so we're really just checking for the key to be part of the dictionary or not.
WordPress 6.9 returns post type supports as either bool or array, so we use JsonValue wrapped in PostTypeSupportsValue for flexibility. Changes: - Add PostTypeSupportsValue type wrapping JsonValue - Update PostTypeSupportsMap to use Arc<PostTypeSupportsValue> - Update test assertion to use as_json_bool() method
oguzkocer
force-pushed
the
fix/post-type-supports-json-value
branch
from
7f86913 to
3161a4e
Compare
Add a `supports` method to `PostTypeSupportsMap` for Rust usage and a `post_type_supports` free function for FFI clients to check if a post type supports a specific feature by key presence. Includes documentation explaining the assumption that key presence implies support, regardless of the associated value.
oguzkocer
force-pushed
the
fix/post-type-supports-json-value
branch
from
3161a4e to
bb2ccd9
Compare
@jkmassel This should be addressed in bb2ccd9. Let me know if this works for you or not. Note that there is some weirdness to this design because we are basically bypassing the possible |
Addresses a breaking change discovered in #1047: WordPress 6.9 returns post type
supportsas eitherboolor array, so we useJsonValuewrapped inPostTypeSupportsValuefor flexibility.