Integrate uniffi-swift-helper #451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uniffi-swift-helper is a new package for developing and releasing Swift wrapper of unffi packages. It's still a WIP. I'm opening this PR to get early feedback.
I will talk about
uniffi-swift-helperimplementation details in its own PR when the WIP is ready for review. In this PR, I'll just talk about "side effects" that comes withuniffi-swift-helper.Package.swiftis auto-generated.The
Package.swiftfile is removed from git. Runmake generate-swift-package-manifestto generatePackage.swiftat the root directory. That would be the first thing to do locally and on CI.The
makecommand invokesuniffi-swift-helperto set up Rust packages, swift wrappers, and their dependencies.Building xcframework
The make commands (
make xcframework,make xcframework-only-macos, etc) is still there. But it now invokesuniffi-swift-helperinternally.