Fix: add null check for comment in wp_cache_get_postid_from_comment()#1043
Open
DeveloperBatuhanALGUL wants to merge 1 commit intoAutomattic:trunkfrom
Conversation
get_comment() can return null when a comment has already been deleted by the time the cache-clear routine runs. This adds an early return to skip the cache update gracefully instead of triggering a PHP warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1014
get_comment() returns null when a comment has already been deleted by
the time the cache-clear routine runs. The existing code attempts to
access array offsets on that null value immediately after, which
triggers a PHP Warning on PHP 8.x.
This adds an early return right after get_comment() so the function
exits cleanly when the comment no longer exists, rather than
proceeding with a null value and generating noise in the error log.
Tested on PHP 8.3.8 / WordPress 6.7 / WP Super Cache 3.1.0.