Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minitv frontend #1074

Closed
wants to merge 5 commits into from
Closed

Conversation

Shiv10122003
Copy link

@Shiv10122003 Shiv10122003 commented Feb 7, 2025

Closes:

  • Issue Title: add mini tv clone
  • Your Name: Shivam tripathi
  • Your Role:
    Iwoc

Describe the add-ons or changes you've made 📃

Screenshots 📷

Type of change ☑️

What sort of change have you made:

  • Bug fix
  • New feature
  • Code style update (formatting, local variables)
  • Documentation update
  • Database update

Note to reviewers 📄

Copy link

vercel bot commented Feb 7, 2025

@Shiv10122003 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Feb 7, 2025

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Shiv10122003
Copy link
Author

@Avdhesh-Varshney please review it

@Avdhesh-Varshney
Copy link
Owner

@Shiv10122003 Have you read the guidelines?

@Shiv10122003
Copy link
Author

yes sir

@Avdhesh-Varshney Avdhesh-Varshney added the Warning: Follow Guidelines https://github.com/Avdhesh-Varshney/WebMasterLog/issues/108 label Feb 7, 2025
@Shiv10122003
Copy link
Author

Sir what guide lines I have not followed

@Shiv10122003
Copy link
Author

Shiv10122003 commented Feb 7, 2025

Only ihave to add readme file as well as directory name change

@Shiv10122003
Copy link
Author

sir i have updated file acc to guidelines @Avdhesh-Varshney

@Avdhesh-Varshney
Copy link
Owner

Good, But you have to enlist your project in main README file and data.json file.

@Shiv10122003
Copy link
Author

Shiv10122003 commented Feb 7, 2025

sir i have updated data.json and in main readme file nothing is added please merge

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should enlist your project in main README file also

## :zap: Screenshots 📸
<!-- add the screenshot of the project (Mandatory) -->

<img src='./Amazon-tv-Clone.webp'>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add screenshot.webp file aside to index.html file

@Shiv10122003
Copy link
Author

Shiv10122003 commented Feb 9, 2025

@Avdhesh-Varshney please check and merge

@Avdhesh-Varshney
Copy link
Owner

@Avdhesh-Varshney please check and merge

Add a screenshot file of your application and enlist your project in main readme file

@Avdhesh-Varshney Avdhesh-Varshney added Flag: Invalid Flag: Inactive and removed Status: Requested Changes Warning: Follow Guidelines https://github.com/Avdhesh-Varshney/WebMasterLog/issues/108 labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants