-
-
Notifications
You must be signed in to change notification settings - Fork 215
feat(distro/nix/niri): add a hack for config includes with niri flake #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(distro/nix/niri): add a hack for config includes with niri flake #1239
Conversation
LuckShiba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, this will be very good for users that use niri-flake while we don't get includes in the upstream! A few comments though.
24fa8a6 to
2c146fe
Compare
23901bb to
022b89e
Compare
|
Looks good to me, and is working here :) |
022b89e to
79bb707
Compare
|
I've got overrides wrong initially. Fixed |
ad68a90 to
1c03077
Compare
|
Looks like I've completely forgot about the border special case. Working on a fix UPD. fixed |
1c03077 to
05b9f65
Compare
Good catch. Can't we simply add the fixes in the generated config.kdl file rather than in another file? I guess this way may be good if we need more fixes which touches the same parts in the future, but will these cases happen? |
Yes, we can. It's just a matter of preference ¯\_(ツ)_/¯
Theoretically, yes. Niri-flake may not add support for new stuff until that rewrite happens, but every new niri version can introduce new changes that may require fixes like this one. But I think my solution is definitely overengineered) |
It surely is, but I guess we can keep it that way for now. I'll wait on @marcusramberg's input on this and we can merge :) |
05b9f65 to
a91f5ef
Compare
After a comparison I think that a single config.kdl is cleaner and a little bit easier to work with |
4166082 to
cf4989e
Compare
It works fine but needs all dms-generated config files to be present
cf4989e to
936c7b4
Compare
|
Lgtm :) |
It works fine but needs all dms-generated config files to be present
That hack should be replaced with proper config includes after sodiboo/niri-flake#1548 merge
The only problem is that optional includes aren't released yet.