Skip to content

Feature - Aggregate event stream inspection #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

stefanmirkovic
Copy link
Contributor

No description provided.

@stefanmirkovic stefanmirkovic self-assigned this May 2, 2025
…as (JSON/XML)

Implement backend pagination while preserving existing features
Copy link
Collaborator

@CodeDrivenMitch CodeDrivenMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As discussed, we might want to do follow-up PRs for propagating dlq and entity state limitations

timestamp = event.timestamp,
payloadType = event.payloadType.toString(),
payload = if (includePayload)
serializer.serialize(event.payload, String::class.java).data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this extension function:

private fun String?.truncate(i: Int): String? {
        if(this == null || this.length <= i) {
            return this
        }
        return this.substring(0, i) + "... [truncated to $i characters]"
    }

We can do here:

Suggested change
serializer.serialize(event.payload, String::class.java).data
serializer.serialize(event.payload, String::class.java).data.truncate(50*1024)

type = query.type,
entityId = query.entityId,
maxSequenceNumber = query.maxSequenceNumber,
state = it
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A double let with overshadowing it generally is not the best practice. Please name the it :)

In addition, with the extension function to truncate:

Suggested change
state = it
state = state.truncate(2 * 1024 * 1024) // truncate to 2MB

stefanmirkovic and others added 2 commits June 5, 2025 14:33
…ted-features-limitations

Add SetupPayload DLQ and Domain Events Insights to supported features
Copy link

sonarqubecloud bot commented Jun 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend This issue contains backend changes Priority 2: Should Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants