-
Notifications
You must be signed in to change notification settings - Fork 0
Feature - Aggregate event stream inspection #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…as (JSON/XML) Implement backend pagination while preserving existing features
...client/src/main/java/io/axoniq/console/framework/application/AggregateEventStreamProvider.kt
Outdated
Show resolved
Hide resolved
console-framework-client/src/main/java/io/axoniq/console/framework/DomainEventAccessMode.java
Outdated
Show resolved
Hide resolved
console-framework-client-api/src/main/java/io/axoniq/console/framework/api/Routes.kt
Outdated
Show resolved
Hide resolved
console-framework-client-api/src/main/java/io/axoniq/console/framework/api/aggregateApi.kt
Outdated
Show resolved
Hide resolved
...client/src/main/java/io/axoniq/console/framework/application/AggregateEventStreamProvider.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As discussed, we might want to do follow-up PRs for propagating dlq and entity state limitations
timestamp = event.timestamp, | ||
payloadType = event.payloadType.toString(), | ||
payload = if (includePayload) | ||
serializer.serialize(event.payload, String::class.java).data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this extension function:
private fun String?.truncate(i: Int): String? {
if(this == null || this.length <= i) {
return this
}
return this.substring(0, i) + "... [truncated to $i characters]"
}
We can do here:
serializer.serialize(event.payload, String::class.java).data | |
serializer.serialize(event.payload, String::class.java).data.truncate(50*1024) |
type = query.type, | ||
entityId = query.entityId, | ||
maxSequenceNumber = query.maxSequenceNumber, | ||
state = it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A double let
with overshadowing it
generally is not the best practice. Please name the it :)
In addition, with the extension function to truncate:
state = it | |
state = state.truncate(2 * 1024 * 1024) // truncate to 2MB |
…ted-features-limitations Add SetupPayload DLQ and Domain Events Insights to supported features
|
No description provided.