Update azd templates #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add dependencies between modules - Add pwsh scripts to purge AOAI and APIM instances
sinedied
reviewed
May 23, 2024
| @@ -123,6 +126,9 @@ module apim 'core/gateway/apim.bicep' = { | |||
| module api 'app/apim-api.bicep' = { | |||
| name: 'api' | |||
| scope: resourceGroup | |||
| dependsOn: [ | |||
There was a problem hiding this comment.
not needed, as there are already params depending on both these resources. Bicep linter should report it
| @@ -108,6 +108,9 @@ module openAi2 'core/ai/cognitiveservices.bicep' = { | |||
| module apim 'core/gateway/apim.bicep' = { | |||
| name: 'apim' | |||
| scope: resourceGroup | |||
| dependsOn: [ | |||
There was a problem hiding this comment.
should not be needed, only the child API created on this APIM requires the dependencies
| @@ -156,6 +162,9 @@ module monitoring 'core/monitor/monitoring.bicep' = { | |||
| module openAi1RoleApim 'core/security/role.bicep' = { | |||
| scope: resourceGroup | |||
| name: 'openai1-role-apim' | |||
| dependsOn: [ | |||
There was a problem hiding this comment.
not needed, apim is automatically recognized as a dependency because of the param.
There's no dependency on openAi1 as the role is set at RG scope
| @@ -171,6 +180,9 @@ module openAi1RoleApim 'core/security/role.bicep' = { | |||
| module openAi2RoleApim 'core/security/role.bicep' = { | |||
| scope: resourceGroup | |||
| name: 'openai2-role-apim' | |||
| dependsOn: [ | |||
There was a problem hiding this comment.
not needed, apim is automatically recognized as a dependency because of the param.
There's no dependency on openAi1 as the role is set at RG scope
Since the scope has change to RG, this second one role is redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to: