Skip to content

feat: add ServiceAccountImagePullProfile for identity-binding-based image pull #7596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Devinwong merged 2 commits into from
Jan 16, 2026
Merged

feat: add ServiceAccountImagePullProfile for identity-binding-based image pull #7596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0449b7
feat: setup kubelet config to support ib-based image pull
qweeah Jan 16, 2026
f082dcc
test: data
qweeah Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions aks-node-controller/parser/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ func getCSEEnv(config *aksnodeconfigv1.Configuration) map[string]string {
"LOCALDNS_MEMORY_LIMIT": getLocalDnsMemoryLimitInMb(config),
"LOCALDNS_GENERATED_COREFILE": getLocalDnsCorefileBase64(config),
"DISABLE_PUBKEY_AUTH": fmt.Sprintf("%v", config.GetDisablePubkeyAuth()),
"SERVICE_ACCOUNT_IMAGE_PULL_ENABLED": fmt.Sprintf("%v", config.GetServiceAccountImagePullProfile().GetEnabled()),
"SERVICE_ACCOUNT_IMAGE_PULL_DEFAULT_CLIENT_ID": config.GetServiceAccountImagePullProfile().GetDefaultClientId(),
"SERVICE_ACCOUNT_IMAGE_PULL_DEFAULT_TENANT_ID": config.GetServiceAccountImagePullProfile().GetDefaultTenantId(),
"IDENTITY_BINDINGS_LOCAL_AUTHORITY_SNI": config.GetServiceAccountImagePullProfile().GetLocalAuthoritySni(),
}

for i, cert := range config.CustomCaCerts {
Expand Down
429 changes: 226 additions & 203 deletions aks-node-controller/pkg/gen/aksnodeconfig/v1/config.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

173 changes: 173 additions & 0 deletions aks-node-controller/pkg/gen/aksnodeconfig/v1/service_account_image_pull_profile.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions aks-node-controller/proto/aksnodeconfig/v1/config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import "aksnodeconfig/v1/kubelet_config.proto";
import "aksnodeconfig/v1/localdns_config.proto";
import "aksnodeconfig/v1/network_config.proto";
import "aksnodeconfig/v1/runc_config.proto";
import "aksnodeconfig/v1/service_account_image_pull_profile.proto";
import "aksnodeconfig/v1/teleport_config.proto";

option go_package = "github.com/Azure/agentbaker/aks-node-controller/pkg/gen/aksnodeconfig/v1;aksnodeconfigv1";
Expand Down Expand Up @@ -163,4 +164,7 @@ message Configuration {
// If it's not set, the default value will be nil, but will be set to false on the VHD.
// That is, the default behavior is to enable ssh public key authentication.
optional bool disable_pubkey_auth = 42;

// Service account based image pull profile configuration
ServiceAccountImagePullProfile service_account_image_pull_profile = 43;
}
20 changes: 20 additions & 0 deletions aks-node-controller/proto/aksnodeconfig/v1/service_account_image_pull_profile.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
syntax = "proto3";

package aksnodeconfig.v1;

option go_package = "github.com/Azure/agentbaker/aks-node-controller/pkg/gen/aksnodeconfig/v1;aksnodeconfigv1";

// ServiceAccountImagePullProfile contains configuration for service account based image pull authentication
message ServiceAccountImagePullProfile {
// Specifies whether service account based image pull is enabled
bool enabled = 1;

// Default client ID to use for image pull authentication
string default_client_id = 2;

// Default tenant ID to use for image pull authentication
string default_tenant_id = 3;

// Local authority SNI for identity bindings
string local_authority_sni = 4;
}
Loading
Loading