feat: ensure successful blob upload without prefetch optimization enabled #7613
Conversation
zachary-bailey
requested review from
AbelHu,
Devinwong,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
phealy,
r2k1 and
timmy-wright
as code owners
| capture_benchmark "${SCRIPT_NAME}_create_sig_image_version" | ||
|
|
||
| if [ "${ENVIRONMENT,,}" = "tme" ] || [ "${GENERATE_PUBLISHING_INFO,,}" = "false" ]; then | ||
| if [ "${ENVIRONMENT,,}" = "tme" ] && [ "${GENERATE_PUBLISHING_INFO,,}" = "false" ]; then |
There was a problem hiding this comment.
so this is to ensure that we always remove the blob from staging assuming we aren't publishing AND we're in TME?
I'm just wondering why we're changing the OR to an AND here
There was a problem hiding this comment.
Because if it was OR, then just by being in TME we would erase the blob, which doesn't work for us since its now copied in a later pipeline step. So copying the blob to immutable storage would always fail
There was a problem hiding this comment.
but if were in TME AND GENERATE_PUBLISHING _INFO is false, then we know we can safely delete, because that later pipeline step will never run
There was a problem hiding this comment.
but come to think of it, this should probably only evaluate the value of GENERATE_PUBLISHING_INFO now
What type of PR is this?
/kind feat
What this PR does / why we need it:
This PR adds logic to dynamically determine the proper storage account to initially upload blobs to, in addition to some general cleanup to prevent code duplication.
Which issue(s) this PR fixes:
Failing pipelines when prefetch optimization is not enabled.
Requirements: