Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vWAN with single subscription deployment bug fix #1472

Merged

Conversation

rozkurt
Copy link
Contributor

@rozkurt rozkurt commented Nov 13, 2023

Overview/Summary

Fixed a bug in the portal accelerator experience when deploying with single platform subscription and selecting virtual WAN networking topology - Invalid Template error. Added missing parameters for recently introduced vWAN Hub features into ES Lite Only deployment for vWAN.

GitHub Issue: Bug Report Deployment template validation fails when selecting Virtual WAN and single subscription #1470

This PR fixes/adds/changes/removes

  1. Updated eslzArm.json

Breaking Changes

  1. N/A

Testing Evidence

image
image
image
image

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone added bug Something isn't working PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments labels Nov 13, 2023
@Springstone Springstone marked this pull request as ready for review November 13, 2023 11:42
@Springstone Springstone requested a review from a team as a code owner November 13, 2023 11:42
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit a6caa4f into Azure:main Nov 14, 2023
5 of 6 checks passed
@rozkurt rozkurt deleted the vWAN_with_Single_Subscription_Deployment_Bug_Fix branch November 14, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report Deployment template validation fails when selecting Virtual WAN and single subscription
3 participants