Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deploy-Storage-sslEnforcement.json to resolve issue #1496 #1497

Closed
wants to merge 1 commit into from
Closed

Update Deploy-Storage-sslEnforcement.json to resolve issue #1496 #1497

wants to merge 1 commit into from

Conversation

apocalysque
Copy link

Overview/Summary

removed extraneous brackets to fix syntax errors

Testing Evidence

PS C:\Users\user> New-AzPolicyDefinition -Name Deploy-Storage-sslEnforcement -Policy C:\Users\user\Downloads\Deploy-Storage-sslEnforcement.json -ManagementGroupName management-group

Name : Deploy-Storage-sslEnforcement
ResourceId : /providers/Microsoft.Management/managementGroups/management-group/providers/Microsoft.Authorization/policyDefinitions/Deploy-Storage-sslEnforcement
ResourceName : Deploy-Storage-sslEnforcement
ResourceType : Microsoft.Authorization/policyDefinitions
SubscriptionId :
Properties : Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.Policy.PsPolicyDefinitionProperties
PolicyDefinitionId : /providers/Microsoft.Management/managementGroups/management-group/providers/Microsoft.Authorization/policyDefinitions/Deploy-Storage-sslEnforcement

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

removed extraneous brackets to fix syntax errors
@apocalysque
Copy link
Author

@microsoft-github-policy-service agree

@Springstone
Copy link
Member

@apocalysque Many thanks for contributing so actively, however, as highlighted in the issue #1496 the escaping of [ is required for the Bicep engine that generates the policies.json file that does the policy deployment as part of ALZ build. The policies are meant to be deployed as part of Azure Landing Zone, however, if you want to deploy them outside of ALZ, you will need to remove the escape character.

Closing the PR, hope you understand.

@Springstone Springstone closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants