Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AMBA Service Health deployment conditions #1876

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arjenhuitema
Copy link
Contributor

@arjenhuitema arjenhuitema commented Dec 24, 2024

Overview/Summary

Resolves deployment issues related to Service Health alerts. Previously, Service Health was not deployed when selected unless Azure Monitor Baseline Alerts were also selected.

This PR fixes/adds/changes/removes

  1. Fixes deployment conditions for AMBA. Now deploys when enableMonitorBaselines and/or enableServiceHealth is set to Yes
  2. Sets enableAMBAConnectivity (and other initiative assignments) to No when enableMonitorBaselines is No and enableServiceHealth is Yes.
  3. Sets ALZWebhookServiceUri to null if ambaAgServiceHook is empty; otherwise, it uses the value of ambaAgServiceHook. Single platform was missed in Fixes empty parameters for amba service hook and email contact #1818
  4. Sets ALZMonitorActionGroupEmail to null if ambaAgEmailContact is empty; otherwise, it uses the value of ambaAgEmailContact. Single platform was missed in Fixes empty parameters for amba service hook and email contact #1818

Breaking Changes

None

Testing Evidence

Test 1: Dedicated platform

  • AMBA: No
  • Service Health: Yes

image

Test 2: Dedicated platform

  • AMBA: Yes
  • Service Health: Yes

image

Test 3: Single platform

  • AMBA: No
  • Service Health: Yes

image

Test 4: Single platform

  • AMBA: Yes
  • Service Health: Yes

image

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Recommend merging after PolicyRefresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants