fix(vscode): Custom code papercuts #6940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebjobs sdk version, update debugger text (#6758) * build custom code functions project on startup, update webjobs sdk version, update custom code debugger text * automatically discover custom code project directories, build all custom code functions projects in workspace on startup * add tests for verifyIsCodeProject, BuildCodeProjects
…ustom code" to context menu, build on open designer (#6816) * move LA before custom code Functions project in workspace * add context menu item in navigation tree to build custom code functions, build project on open designer instead of activate * add tests for tryGetPeerCustomCodeFunctionsProjects * remove unneeded file, update build on open designer to only build functions project for target LA * update custom code functions build to use our dotnet dependency binaries * update tests
…ions projects (#6853) * move LA before custom code Functions project in workspace * add context menu item in navigation tree to build custom code functions, build project on open designer instead of activate * add tests for tryGetPeerCustomCodeFunctionsProjects * remove unneeded file, update build on open designer to only build functions project for target LA * update custom code functions build to use our dotnet dependency binaries * update tests * add support for multiple functions in custom code functions project * fix tests * add tests for new utils, update getCustomCodeFunctionsProjectMetadata to resolve on parse error * fix naming * normalize paths * win32 path in csproj * build custom code functions project in predebug step
* add pickCustomCodeNetHost command to pick .net8 host process for custom code, update launch config * add tests for pickCustomCodeNetHostProcess * remove lib/custom folder on new project creation (not needed until functions project built), only build on open designer when missing binaries
lambrianmsft
reviewed
Apr 1, 2025
apps/vs-code-designer/src/app/commands/__test__/pickCustomCodeNetHostProcess.test.ts
Show resolved
Hide resolved
…space input validation, update context when creating new functions project (#6961) * fix bug in function name/function app name input validation, update functions projects in context when creating new project * Add tests for FunctionNameStep, FunctionAppNameStep * add test for FunctionAppNamespaceStep
ccastrotrejo
approved these changes
Apr 4, 2025
…es engine for existing LA (#7003) add Create New Project option to create custom code/rules engine for existing LA
* fix test, update error message for noFuncTask local function debugger * add custom code telemetry, update tests * add validation on debug config, function metadata, and selected logic app project when picking custom code .net host process; update tests * update error message * use non-localized strings in telemetry for createCustomCodeFunction
ccastrotrejo
approved these changes
Apr 24, 2025
DanielleCogs
added a commit
that referenced
this pull request
May 16, 2025
* feat(designer): Add expand/collapse all button to controls and rework controls appearance (#7036) * feat(designer): Add expand/collapse all button to controls and rework controls appearance * add snapshots --------- Co-authored-by: Travis Vu <[email protected]> * fix(deigner): Position nodes at top of designer on start instead of middle (#7038) fix(deigner): Position nodes at top of designer on start Co-authored-by: Travis Vu <[email protected]> * fix(designer): Fix issue where retry policy error wouldn't disappear when retry policy changed (#7039) Co-authored-by: Travis Vu <[email protected]> * feat(designer): Update pinned node to alternated selected node (#7037) * First approach to alternate node * Update all to use alternateNode * Update styles * Revert back files * Update unpin in panel header * Update e2e tests * Fix typo * Remove console log * fix(designer): Add styles for code tags inside the chat bubble (#7044) Add styles to break workd and white spaces for code tags inside the chat bubble * fix(designer): Agent workflow fixes (#7046) * fix checkbox * label weight * upodate button style * chore(release): 5.81.0 * feat(vscode): Automatically update function core tools and dotnet binaries (#7045) * Update logic to automatically update function core tools and dotnet * Auto starts design time api after succesfully downloaded it * fix(designer): Do not serialize user messages if empty (#7051) fix user messages * chore(release): 5.82.0 * chore(release): 5.83.0 * feat(Templates): Infer TriggerType from workflow json (#7047) * added trigger type * enabled stateful stateless * shows trigger on profile page from inferred only if single workflow * removed getTriggerFromDefinition from templates UI rendering * intl sku and host kinds * intl state type on workflows tab * fix(designer): Update value in services to support stateful in agentic (#7054) * Update value in services to support stateful * Update logic * fix(designer): Load agent run data from general run data (#7055) Add agent decision to load data for first run * fix(vscode): Add unit test name validation check for existing test/folder with same name (#7056) * add check for existing test with same name in unit test name validation * differentiate between existing unit test and duplicate folder name * add tests * Update production-build.yml * Revert "Update production-build.yml" This reverts commit 30e8eef. * chore(release): 5.84.0 * chore(release): 5.85.0 * feat(designer): Add logic to not validate freshly created agent workflow (#7057) * Add logic to not validate freshly created agent workflow * Add validation for connection reference equals to mock connection reference * feat(Templates): Added trigger description input on basics + review steps (#7058) * Added trigger description input on template basics * Fixed build error * Fixed build error * Please fix build error * fix(vscode): Test authoring fixes (#7059) * ensure Tests folder remains at end of workspace when new projects are added * prevent partial creation of unit tests from invalid workflows, improve error handling for workflows missing trigger, fix test templates * make updateTestsSln use extension dotnet dependency binaries (currently rely on user's local dotnet installation) * chore(release): 5.86.0 * fix(vscode): Add validation for data map name (#7063) Add validation for data map name * feat(Templates): Added template trigger description validation (#7064) Added description validation * chore(release): 5.87.0 * feat(Templates): Custom Templates UI Enhancements (#7062) * lengthen main part * fixed parameter * hide toaster when panel is open * opened all for multi workflow * fixed typo * fix(Templates): Fixed template trigger description validation (#7067) Fixed template trigger description validation * chore(release): 5.88.0 * fix(designer): Uncasting parameters based on url encoding (#7071) * Add validation to shouldUncast based on parameter path * Add should encode base on metadata * Remove console log * Add e2e tests to check right renderization * fix(designer): Update agent settings and intl text (#7072) * Update settings and intl text * Update styles * Update styles * fix(vscode): Remove user-facing commands for automated testing (#7073) remove user-facing commands for unit testing * fix(vscode): Create separate instance of design time for each logic app, remove unneeded prompts for logic app (#7007) * Create separate instance of design time for each logic app * remove unneeded prompts for logic app (get from context) on: launch workflow debugger, parameterize connections, verify connection keys, configure .net CLI, generate deployment scripts, unit test authoring; remove unneeded unit commands * fix test for saveBlankUnitTest * add tests for parameterizeConnections and connectionKeys * add tests for getWorkspaceLogicAppFolders and tryGetAllLogicAppProjectRoots * change bundle version to map to support different versions for each LA, remove parallel start design time API calls to avoid possible port conflict/race condition * re-add parallel design time API startup, significant increase in start time w multiple logic apps * update parameterizeConnections to only prompt for global setting once * re-add project prompt to verifyLocalConnectionKeys to ensure Azure connector details are set correctly, correct context type in unit test files, update tests * fix(designer): Update channels tab to be more information and abstract out details not required right now (#7077) * change panel * add learn more * update 1 * fix(vscode): Standardize commands titles (#7078) Standarize commands titles * fix(Templates): Fixed issue with templates connections during creation (#7079) Fixed issue with templates connections during creation * chore(release): 5.89.0 * fix(designer): Edit pass on agent UX strings. Replace "Click" with the more accessible term, "Select". (#7066) * strings.json - Edit pass on agent UX strings and replace "Click" with "Select" - "Click" isn't accessible terminology. * Update first batch * Update second batch * Update third batch * Update fourth batch * Update final batch * Updated snapshots with new text * Update text * Update e2e tests * Update e2e tests --------- Co-authored-by: Carlos Emiliano Castro Trejo <[email protected]> * feat(Templates): Custom Templates Validation & Error Handling (#7061) * add manifest and workflows error states * added validate workflowmanifestsdata and validatetemplatemanifest * modified errors scneario * added logic for manifest validation on change * added error showing for profile tab * trigger validation * run validaiton on change * no parameters or connections added * changed validation method to runValidation check * mid progress * added workflowname hint * parameters validation * added validation for parameter default * removed unncessary whitespace * run validation on title and summary for workflows only when single multi workflow * added tests * toBe to toStrictEqual * added validateTemplateManifestValue tests * fixed valiation test and logic * fixed ? check * docs(vscode): Update Readme - unit test announcement (#7082) docs(VSCode): Update Readme - unit test announcement Update VS Code Extension readme page to include Unit test public preview announcement. * feat(vscode): Update Rules Engine files and remove preview (#7080) * Update rules files and add schemaUser file * Remove preview string * Add schema user file to project * Update file * Update file conenten * Update file name * Remove comment * Update wizard logic * fix(vscode): prompt appearing when empty workspace opened (#7085) update getWorkspaceLogicAppFolders to return empty array if no workspace folders open (instead of prompting), update tests * fix(designer): Update messages strings for operation deserializer (#7083) operationdeserializer.ts: Editorial pass on UX strings * fix(designer): Agentic workflows fit and finish 1 (#7088) * add teaching popup * refactor * fix imports * agent tool style * update icon * update text * fix test * fix(vscode): Custom code papercuts (#6940) * fix(vscode): build custom code functions project on startup, update webjobs sdk version, update debugger text (#6758) * build custom code functions project on startup, update webjobs sdk version, update custom code debugger text * automatically discover custom code project directories, build all custom code functions projects in workspace on startup * add tests for verifyIsCodeProject, BuildCodeProjects * fix(vscode): .Net 8 Custom Code: fix workspace settings, add "build custom code" to context menu, build on open designer (#6816) * move LA before custom code Functions project in workspace * add context menu item in navigation tree to build custom code functions, build project on open designer instead of activate * add tests for tryGetPeerCustomCodeFunctionsProjects * remove unneeded file, update build on open designer to only build functions project for target LA * update custom code functions build to use our dotnet dependency binaries * update tests * feat(vscode): Add support for multiple functions in custom code functions projects (#6853) * move LA before custom code Functions project in workspace * add context menu item in navigation tree to build custom code functions, build project on open designer instead of activate * add tests for tryGetPeerCustomCodeFunctionsProjects * remove unneeded file, update build on open designer to only build functions project for target LA * update custom code functions build to use our dotnet dependency binaries * update tests * add support for multiple functions in custom code functions project * fix tests * add tests for new utils, update getCustomCodeFunctionsProjectMetadata to resolve on parse error * fix naming * normalize paths * win32 path in csproj * build custom code functions project in predebug step * fix(vscode): .Net 8 custom code debugger fix (#6897) * add pickCustomCodeNetHost command to pick .net8 host process for custom code, update launch config * add tests for pickCustomCodeNetHostProcess * remove lib/custom folder on new project creation (not needed until functions project built), only build on open designer when missing binaries * Update name * Update unit tests * fix(vscode): bug in function name/function app name/function app namespace input validation, update context when creating new functions project (#6961) * fix bug in function name/function app name input validation, update functions projects in context when creating new project * Add tests for FunctionNameStep, FunctionAppNameStep * add test for FunctionAppNamespaceStep * feat(vscode): Add Create New Project option to create custom code/rules engine for existing LA (#7003) add Create New Project option to create custom code/rules engine for existing LA * fix(vscode): Custom code telemetry, error handling (#7081) * fix test, update error message for noFuncTask local function debugger * add custom code telemetry, update tests * add validation on debug config, function metadata, and selected logic app project when picking custom code .net host process; update tests * update error message * use non-localized strings in telemetry for createCustomCodeFunction * Remove rules engine preview --------- Co-authored-by: Carlos Emiliano Castro Trejo <[email protected]> * chore(release): 5.90.0 * chore(release): 5.91.0 * feat(Templates): Review and Publish Re-ordering (#7087) * changed review publish order and moved sku * removed publish * changed review publish tab to review tab * chnaged footer content * localized strings and changed overflow to auto * fix(Templates): Workflows tab content fixes (#7092) * fixed workflows page wordings * fixed select workflow service * changed another select wording * fix(desinger): Add validation for agent tool name (#7091) * Add validation for agent tool name * Serialize correctly * Add specific error message * chore(release): 5.92.0 * fix(templates): Using test storage account and removing endpoint checkbox from test pages (#7095) * fix(templates): Using test storage account and removing endpoint checkbox from test pages * Removing the test sub --------- Co-authored-by: Priti Sambandam <[email protected]> --------- Co-authored-by: Travis Harris <[email protected]> Co-authored-by: Travis Vu <[email protected]> Co-authored-by: Carlos Emiliano Castro Trejo <[email protected]> Co-authored-by: Krrish Mittal <[email protected]> Co-authored-by: [email protected] <takyyon> Co-authored-by: [email protected] <ccastrotrejo> Co-authored-by: Elaina Lee <[email protected]> Co-authored-by: Andrew Eldridge <[email protected]> Co-authored-by: [email protected] <hartra344> Co-authored-by: Riley Evans <[email protected]> Co-authored-by: [email protected] <rllyy97> Co-authored-by: Esther Fan <[email protected]> Co-authored-by: Carlos Emiliano Castro Trejo <[email protected]> Co-authored-by: Wagner Silveira <[email protected]> Co-authored-by: preetriti1 <[email protected]> Co-authored-by: Priti Sambandam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Current Behavior
New Behavior
Impact of Change
Test Plan
Screenshots or Videos (if applicable)
N/A