Skip to content

feat(Templates): Custom Templates Tab Management #6997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 14, 2025

Conversation

Elaina-Lee
Copy link
Contributor

@Elaina-Lee Elaina-Lee commented Apr 10, 2025

Type of Change

  • Bug fix
  • Feature
  • Other

Current Behavior

Tab will only be enabled when 1. enableWizard is true and 2. isWizardUpdating is not true.

  • enableWizard is true when there are selected workflows, meaning tabs will be disabled when no workflows are selected
  • isWizardUpdating is used to determine temporarily disabling tabs or setting spinner/disabling panel until initialization or deletion is complete
    To be coming: With each tab validation, we may turn the tab status to error

Impact of Change

  • This is a breaking change.

Test Plan

  • UI elements are still to be polished (i.e. tab icons will not be always in progress once validation is implemented)
  • Validation tests will be added along with validation logic & UI in the next PR (error tab status is not fixed yet)

Screenshots or Videos (if applicable)

Recording.2025-04-10.122323.mp4

@Elaina-Lee Elaina-Lee marked this pull request as ready for review April 10, 2025 21:20
@Elaina-Lee Elaina-Lee requested a review from rllyy97 April 11, 2025 00:34
@Elaina-Lee Elaina-Lee merged commit 63111c3 into main Apr 14, 2025
13 checks passed
@Elaina-Lee Elaina-Lee deleted the elaina/wizardTabManage branch April 14, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants