Skip to content

Commit

Permalink
Update osutil for Ubuntu 18+ (#1865)
Browse files Browse the repository at this point in the history
  • Loading branch information
pgombar authored Apr 24, 2020
1 parent ed5cb57 commit 62227d6
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
4 changes: 3 additions & 1 deletion azurelinuxagent/common/osutil/factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ def _get_osutil(distro_name, distro_code_name, distro_version, distro_full_name)
return Ubuntu14OSUtil()
elif Version(distro_version) in [Version('16.04'), Version('16.10'), Version('17.04')]:
return Ubuntu16OSUtil()
elif Version(distro_version) in [Version('18.04')]:
elif Version(distro_version) in [Version('18.04'), Version('18.10'),
Version('19.04'), Version('19.10'),
Version('20.04')]:
return Ubuntu18OSUtil()
elif distro_full_name == "Snappy Ubuntu Core":
return UbuntuSnappyOSUtil()
Expand Down
2 changes: 1 addition & 1 deletion azurelinuxagent/common/osutil/ubuntu.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def mount_cgroups(self):

class Ubuntu18OSUtil(Ubuntu16OSUtil):
"""
Ubuntu 18.04
Ubuntu 18.04, 18.10, 19.04, 19.10, 20.04
"""
def __init__(self):
super(Ubuntu18OSUtil, self).__init__()
Expand Down
9 changes: 8 additions & 1 deletion tests/common/osutil/test_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,19 @@ def test_get_osutil_it_should_return_ubuntu(self):
self.assertEquals(ret.get_service_name(), "walinuxagent")

ret = _get_osutil(distro_name="ubuntu",
distro_code_name="",
distro_code_name="bionic",
distro_version="18.04",
distro_full_name="")
self.assertTrue(type(ret) == Ubuntu18OSUtil)
self.assertEquals(ret.get_service_name(), "walinuxagent")

ret = _get_osutil(distro_name="ubuntu",
distro_code_name="focal",
distro_version="20.04",
distro_full_name="")
self.assertTrue(type(ret) == Ubuntu18OSUtil)
self.assertEquals(ret.get_service_name(), "walinuxagent")

ret = _get_osutil(distro_name="ubuntu",
distro_code_name="",
distro_version="10.04",
Expand Down

0 comments on commit 62227d6

Please sign in to comment.