Skip to content

Conversation

chris-pinola-rf
Copy link

Checklist

  • The title of the PR is clear and informative
  • If applicable, the changes made in the PR have proper test coverage
  • Issues addressed by the PR are mentioned in the description followed by Fixes.

Description

If .Values.appgw.prohibitedTargets contains more than one element, helm lint (v3.7) fails with:

[ERROR] templates/crds.yaml: unable to parse YAML: invalid Yaml document separator: apiVersion: appgw.ingress.k8s.io/v1

See for more info: helm/helm#10149 (comment)

I updated the snapshot test case and regenerated the output with:

$ cd helm/ingress-azure/tests
$ rm -rf snapshots/ && RENDER_SNAPSHOTS=true go test chart_test.go snapshots.go

Fixes

Could not find any.

@chris-pinola-rf
Copy link
Author

@microsoft-github-policy-service agree company="Wonder Group, Inc"

@chris-pinola-rf chris-pinola-rf changed the title Fix helm lint error with multiple AzureIngressProhibitedTarget CRDs fix: helm lint error with >1 AzureIngressProhibitedTarget May 5, 2025
@chris-pinola-rf

This comment was marked as outdated.

@chris-pinola-rf
Copy link
Author

Hi @sean-jeffrey - it looks like you've taken over maintenance of the chart, would you mind reviewing this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant