Skip to content

LRO breaking mitigation #3573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

LRO breaking mitigation #3573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b65486d
Keep the legacy operations
MaryGao Oct 27, 2025
f3ccf1e
Merge branch 'main' into LRO-breaking-mitigation
Nov 4, 2025
e10b7d6
Update the LRO interface to SimplePollerLike
Nov 4, 2025
b022a1b
Update the polling to support POST paging
Nov 5, 2025
0c63ff5
Update the post paging support
Nov 5, 2025
787de32
Update the name
Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...ment/generated/typespec-ts/sdk/test/arm-test/review/arm-networkanalytics.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
```ts

import { AbortSignalLike } from '@azure/abort-controller';
import type { CancelOnProgress } from '@azure/core-lro';
import { ClientOptions } from '@azure-rest/core-client';
import { OperationOptions } from '@azure-rest/core-client';
import { OperationState } from '@azure/core-lro';
Expand Down Expand Up @@ -183,6 +184,12 @@ export interface DataProductsListRolesAssignmentsOptionalParams extends Operatio
// @public
export interface DataProductsOperations {
addUserRole: (resourceGroupName: string, dataProductName: string, body: RoleAssignmentCommonProperties, options?: DataProductsAddUserRoleOptionalParams) => Promise<RoleAssignmentDetail>;
// Warning: (ae-forgotten-export) The symbol "SimplePollerLike" needs to be exported by the entry point index.d.ts
//
// @deprecated (undocumented)
beginCreate: (resourceGroupName: string, dataProductName: string, resource: DataProduct, options?: DataProductsCreateOptionalParams) => Promise<SimplePollerLike<OperationState<DataProduct>, DataProduct>>;
// @deprecated (undocumented)
beginCreateAndWait: (resourceGroupName: string, dataProductName: string, resource: DataProduct, options?: DataProductsCreateOptionalParams) => Promise<DataProduct>;
create: (resourceGroupName: string, dataProductName: string, resource: DataProduct, options?: DataProductsCreateOptionalParams) => PollerLike<OperationState<DataProduct>, DataProduct>;
delete: (resourceGroupName: string, dataProductName: string, options?: DataProductsDeleteOptionalParams) => PollerLike<OperationState<void>, void>;
generateStorageAccountSasToken: (resourceGroupName: string, dataProductName: string, body: AccountSas, options?: DataProductsGenerateStorageAccountSasTokenOptionalParams) => Promise<AccountSasToken>;
Expand Down
97 changes: 71 additions & 26 deletions ...tics.Management/generated/typespec-ts/sdk/test/arm-test/src/classic/dataProducts/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,52 +40,53 @@ import {
} from "../../models/models.js";
import { PagedAsyncIterableIterator } from "../../static-helpers/pagingHelpers.js";
import { PollerLike, OperationState } from "@azure/core-lro";
import { createSimplePoller, SimplePollerLike } from "../../static-helpers/pollingHelpers.js";

/** Interface representing a DataProducts operations. */
export interface DataProductsOperations {
/** List data products by subscription. */
listBySubscription: (
options?: DataProductsListBySubscriptionOptionalParams,
options?: DataProductsListBySubscriptionOptionalParams
) => PagedAsyncIterableIterator<DataProduct>;
/** List data products by resource group. */
listByResourceGroup: (
resourceGroupName: string,
options?: DataProductsListByResourceGroupOptionalParams,
options?: DataProductsListByResourceGroupOptionalParams
) => PagedAsyncIterableIterator<DataProduct>;
/** List user roles associated with the data product. */
listRolesAssignments: (
resourceGroupName: string,
dataProductName: string,
body: Record<string, any>,
options?: DataProductsListRolesAssignmentsOptionalParams,
options?: DataProductsListRolesAssignmentsOptionalParams
) => Promise<ListRoleAssignments>;
/** Remove role from the data product. */
removeUserRole: (
resourceGroupName: string,
dataProductName: string,
body: RoleAssignmentDetail,
options?: DataProductsRemoveUserRoleOptionalParams,
options?: DataProductsRemoveUserRoleOptionalParams
) => Promise<void>;
/** Assign role to the data product. */
addUserRole: (
resourceGroupName: string,
dataProductName: string,
body: RoleAssignmentCommonProperties,
options?: DataProductsAddUserRoleOptionalParams,
options?: DataProductsAddUserRoleOptionalParams
) => Promise<RoleAssignmentDetail>;
/** Initiate key rotation on Data Product. */
rotateKey: (
resourceGroupName: string,
dataProductName: string,
body: KeyVaultInfo,
options?: DataProductsRotateKeyOptionalParams,
options?: DataProductsRotateKeyOptionalParams
) => Promise<void>;
/** Generate sas token for storage account. */
generateStorageAccountSasToken: (
resourceGroupName: string,
dataProductName: string,
body: AccountSas,
options?: DataProductsGenerateStorageAccountSasTokenOptionalParams,
options?: DataProductsGenerateStorageAccountSasTokenOptionalParams
) => Promise<AccountSasToken>;
/** Delete data product resource. */
/**
Expand All @@ -96,119 +97,163 @@ export interface DataProductsOperations {
delete: (
resourceGroupName: string,
dataProductName: string,
options?: DataProductsDeleteOptionalParams,
options?: DataProductsDeleteOptionalParams
) => PollerLike<OperationState<void>, void>;
/** Update data product resource. */
update: (
resourceGroupName: string,
dataProductName: string,
properties: DataProductUpdate,
options?: DataProductsUpdateOptionalParams,
options?: DataProductsUpdateOptionalParams
) => PollerLike<OperationState<DataProduct>, DataProduct>;
/** Retrieve data product resource. */
get: (
resourceGroupName: string,
dataProductName: string,
options?: DataProductsGetOptionalParams,
options?: DataProductsGetOptionalParams
) => Promise<DataProduct>;
/** Create data product resource. */
create: (
resourceGroupName: string,
dataProductName: string,
resource: DataProduct,
options?: DataProductsCreateOptionalParams,
options?: DataProductsCreateOptionalParams
) => PollerLike<OperationState<DataProduct>, DataProduct>;
/** @deprecated use create instead */
beginCreate: (
resourceGroupName: string,
dataProductName: string,
resource: DataProduct,
options?: DataProductsCreateOptionalParams
) => Promise<SimplePollerLike<OperationState<DataProduct>, DataProduct>>;
/** @deprecated use create instead */
beginCreateAndWait: (
resourceGroupName: string,
dataProductName: string,
resource: DataProduct,
options?: DataProductsCreateOptionalParams
) => Promise<DataProduct>;
}

function _getDataProducts(context: NetworkAnalyticsApiContext) {
return {
listBySubscription: (
options?: DataProductsListBySubscriptionOptionalParams,
options?: DataProductsListBySubscriptionOptionalParams
) => listBySubscription(context, options),
listByResourceGroup: (
resourceGroupName: string,
options?: DataProductsListByResourceGroupOptionalParams,
options?: DataProductsListByResourceGroupOptionalParams
) => listByResourceGroup(context, resourceGroupName, options),
listRolesAssignments: (
resourceGroupName: string,
dataProductName: string,
body: Record<string, any>,
options?: DataProductsListRolesAssignmentsOptionalParams,
options?: DataProductsListRolesAssignmentsOptionalParams
) =>
listRolesAssignments(
context,
resourceGroupName,
dataProductName,
body,
options,
options
),
removeUserRole: (
resourceGroupName: string,
dataProductName: string,
body: RoleAssignmentDetail,
options?: DataProductsRemoveUserRoleOptionalParams,
options?: DataProductsRemoveUserRoleOptionalParams
) =>
removeUserRole(
context,
resourceGroupName,
dataProductName,
body,
options,
options
),
addUserRole: (
resourceGroupName: string,
dataProductName: string,
body: RoleAssignmentCommonProperties,
options?: DataProductsAddUserRoleOptionalParams,
options?: DataProductsAddUserRoleOptionalParams
) =>
addUserRole(context, resourceGroupName, dataProductName, body, options),
rotateKey: (
resourceGroupName: string,
dataProductName: string,
body: KeyVaultInfo,
options?: DataProductsRotateKeyOptionalParams,
options?: DataProductsRotateKeyOptionalParams
) => rotateKey(context, resourceGroupName, dataProductName, body, options),
generateStorageAccountSasToken: (
resourceGroupName: string,
dataProductName: string,
body: AccountSas,
options?: DataProductsGenerateStorageAccountSasTokenOptionalParams,
options?: DataProductsGenerateStorageAccountSasTokenOptionalParams
) =>
generateStorageAccountSasToken(
context,
resourceGroupName,
dataProductName,
body,
options,
options
),
delete: (
resourceGroupName: string,
dataProductName: string,
options?: DataProductsDeleteOptionalParams,
options?: DataProductsDeleteOptionalParams
) => $delete(context, resourceGroupName, dataProductName, options),
update: (
resourceGroupName: string,
dataProductName: string,
properties: DataProductUpdate,
options?: DataProductsUpdateOptionalParams,
options?: DataProductsUpdateOptionalParams
) =>
update(context, resourceGroupName, dataProductName, properties, options),
get: (
resourceGroupName: string,
dataProductName: string,
options?: DataProductsGetOptionalParams,
options?: DataProductsGetOptionalParams
) => get(context, resourceGroupName, dataProductName, options),
create: (
resourceGroupName: string,
dataProductName: string,
resource: DataProduct,
options?: DataProductsCreateOptionalParams,
options?: DataProductsCreateOptionalParams
) => create(context, resourceGroupName, dataProductName, resource, options),
beginCreate: async (
resourceGroupName: string,
dataProductName: string,
resource: DataProduct,
options?: DataProductsCreateOptionalParams
): Promise<SimplePollerLike<OperationState<DataProduct>, DataProduct>> => {
const poller = create(
context,
resourceGroupName,
dataProductName,
resource,
options
);
await poller.submitted();
return createSimplePoller(poller);
},
beginCreateAndWait: async (
resourceGroupName: string,
dataProductName: string,
resource: DataProduct,
options?: DataProductsCreateOptionalParams
) => {
return await create(
context,
resourceGroupName,
dataProductName,
resource,
options
);
},
};
}

export function _getDataProductsOperations(
context: NetworkAnalyticsApiContext,
context: NetworkAnalyticsApiContext
): DataProductsOperations {
return {
..._getDataProducts(context),
Expand Down
Loading
Loading