Skip to content

fix: use storagev2 BlobClient #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix: use storagev2 BlobClient #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f479b4
fix: use storagev2 BlobClient
Oct 7, 2025
114f7a7
fix pylint
Oct 7, 2025
b4c25bd
update version and add history entry
Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Release History
===============
0.2.6
++++++
* Use storagev2 utilities to fix `az extension publish` (#529)

0.2.5
++++++
* Add support for Python 3.11, 3.12, and 3.13
Expand Down
2 changes: 1 addition & 1 deletion azdev/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
# license information.
# -----------------------------------------------------------------------------

__VERSION__ = '0.2.5'
__VERSION__ = '0.2.6'
20 changes: 11 additions & 9 deletions azdev/operations/extensions/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def build_extensions(extensions, dist_dir='dist'):

def publish_extensions(extensions, storage_account, storage_account_key, storage_container,
dist_dir='dist', update_index=False, yes=False):
from azure.multiapi.storage.v2018_11_09.blob import BlockBlobService
from azure.multiapi.storagev2.blob.v2022_11_02 import BlobClient

heading('Publish Extensions')

Expand All @@ -329,8 +329,12 @@ def publish_extensions(extensions, storage_account, storage_account_key, storage
for whl_path in whl_files:
whl_file = os.path.split(whl_path)[-1]

client = BlockBlobService(account_name=storage_account, account_key=storage_account_key)
exists = client.exists(container_name=storage_container, blob_name=whl_file)
account_url = f"https://{storage_account}.blob.core.windows.net"
client = BlobClient(account_url=account_url,
container_name=storage_container,
credential=storage_account_key,
blob_name=whl_file)
exists = client.exists()

# check if extension already exists unless user opted not to
if not yes:
Expand All @@ -341,12 +345,10 @@ def publish_extensions(extensions, storage_account, storage_account_key, storage
logger.warning("Skipping '%s'...", whl_file)
continue
# upload the WHL file
client.create_blob_from_path(container_name=storage_container, blob_name=whl_file,
file_path=os.path.abspath(whl_path))
url = client.make_blob_url(container_name=storage_container, blob_name=whl_file)

logger.info(url)
uploaded_urls.append(url)
with open(os.path.abspath(whl_path), 'rb') as f:
client.upload_blob(data=f)
logger.info(client.url)
uploaded_urls.append(client.url)

if update_index:
subheading('Updating Index')
Expand Down