Repository navigation
foundry-cost-control 1.0.0b2: Override cognitiveservices account show in order to use api-version 2026-09-15-preview - #10403
Merged
Ethan Yang (necusjz) merged 4 commits intoSep 30, 2026
Conversation
… 2026-09-15-preview
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Darren Cohen (dargilco)
September 29, 2026 00:05
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation is consistent with the stated purpose and includes appropriate unit and scenario coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Overrides account display to use the preview API and expose cost-control properties.
Changes:
- Adds and registers the preview-backed
account_show. - Adds unit and scenario coverage.
- Bumps the extension version and release history.
| File | Description |
|---|---|
setup.py |
Bumps version to 1.0.0b2. |
HISTORY.rst |
Documents the command override. |
test_foundry_cost_control.py |
Verifies returned cost-control properties. |
test_foundry_cost_control_custom_code.py |
Tests API version and resource ID construction. |
custom.py |
Implements the preview account-show operation. |
commands.py |
Registers the command override. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Collaborator
|
Please fix CI issues |
…st-control-account-show-override
Darren Cohen (dargilco)
changed the title
cognitiveservices account show in order to use api-version 2026-09-15-previewcognitiveservices account show in order to use api-version 2026-09-15-preview
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Ethan Yang (necusjz)
approved these changes
Sep 30, 2026
Collaborator
|
[Release] Update index.json for extension [ foundry-cost-control-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=183447245&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback from internal users, I need to update the extension to also override the "cognitiveservices account show" command, such that it uses the
2026-09-15-previewapi-version, therefore showing the additional properties related to cost-control. No change to the command other than using latest preview api-version. I plan to release this as beta 2 version (1.0.0b2).This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.