Repository navigation
Update ServiceGroup extension to stable API 2026-08-01 - #10435
Open
Meghana Gupta (meghanagupta95) wants to merge 1 commit into
Open
Meghana Gupta (meghanagupta95) wants to merge 1 commit into
Meghana Gupta (meghanagupta95) wants to merge 1 commit into
Conversation
- add criticality support and GA live/playback coverage - remove the preview-only list-ancestors command Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Meghana Gupta (meghanagupta95)
October 6, 2026 17:13
View session
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 10435 in repo Azure/azure-cli-extensions |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The API migration, command removal, serialization changes, documentation, and test coverage are consistent with the stated scope.
Review effort: Balanced
Findings: None
What changed in this PR
Updates ServiceGroup to stable API 2026-08-01, including GA criticality handling and removal of the preview-only ancestor command.
Changes:
- Migrates all commands to the stable API and adds criticality support.
- Removes
list-ancestorsand its associated documentation/tests. - Bumps the extension version and refreshes contract, scenario, and playback coverage.
| File | Description |
|---|---|
src/servicegroup/setup.py |
Bumps version to 1.0.0b2. |
src/servicegroup/README.md |
Documents criticality and removes ancestor usage. |
src/servicegroup/HISTORY.rst |
Records release changes. |
src/servicegroup/azext_servicegroup/_help.py |
Updates CLI examples and command help. |
src/servicegroup/azext_servicegroup/aaz/latest/service_group/__init__.py |
Removes ancestor command registration. |
.../_create.py |
Uses the stable API and supports criticality. |
.../_delete.py |
Uses the stable API. |
.../_list_ancestors.py |
Removes the preview-only command. |
.../_show.py |
Uses the stable API and handles float criticality. |
.../_update.py |
Adds criticality updates using the stable API. |
.../_wait.py |
Uses the stable API and handles float criticality. |
.../tests/latest/test_servicegroup_contract.py |
Verifies API and criticality schemas. |
.../tests/latest/test_servicegroup_scenario.py |
Adds playback-enabled criticality coverage. |
.../recordings/test_servicegroup_crud.yaml |
Refreshes CRUD playback for the GA API. |
.../recordings/test_servicegroup_create_with_nested_parent.yaml |
Refreshes nested hierarchy playback. |
.../recordings/test_servicegroup_list_ancestors.yaml |
Removes obsolete ancestor recording. |
.../recordings/test_servicegroup_create_with_parent.yaml |
Removes obsolete recording. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az service-groupUpdates the ServiceGroup extension to stable API
2026-08-01, adds criticality support, handles the GA service's float-form criticality responses, and removes the preview-onlylist-ancestorscommand. The extension version is bumped to1.0.0b2with refreshed live recordings and playback coverage.Validation
azdev style servicegroup— passedazdev test servicegroup— 5 passedpython scripts/ci/test_index.py -q— passed (9 tests, 2 skipped)General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.